Date: Mon, 13 Nov 2006 09:12:22 +0000
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: David Miller <davem@davemloft.net>, kenneth.w.chen@intel.com,
       akpm@osdl.org, jgarzik@pobox.com, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype
Message-ID: <20061113091222.GA26628@flint.arm.linux.org.uk>
Mail-Followup-To: Al Viro <viro@ftp.linux.org.uk>,
	David Miller <davem@davemloft.net>, kenneth.w.chen@intel.com,
	akpm@osdl.org, jgarzik@pobox.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
References: <000301c703a3$0eedb340$ff0da8c0@amr.corp.intel.com> <20061108.230059.57444310.davem@davemloft.net> <20061109072216.GL29920@ftp.linux.org.uk> <20061108.235548.12921799.davem@davemloft.net> <20061113085223.GR29920@ftp.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061113085223.GR29920@ftp.linux.org.uk>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 22

On Mon, Nov 13, 2006 at 08:52:23AM +0000, Al Viro wrote:
> After doing the above we have the following:
> 
> Platform-dependent:
> __wsum csum_tcpudp_nofold(__be32, __be32, T1, T2, __wsum);
> On arm/arm26: T1 = unsigned short, T2 = unsigned int.
> __sum16 csum_tcpudp_magic(__be32, __be32, unsigned short, T, __wsum);
> On arm/arm26 T is unsigned int, elsewhere it's unsigned short.

Could both become unsigned short or unsigned int.  Would prefer
unsigned int on ARM, since otherwise the compiler generate code to
truncate any variable "int"s to an unsigned short.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/