Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 26 Jun 2021 00:22:52 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Steve Rutherford <srutherford@google.com>
Cc:     Ashish Kalra <Ashish.Kalra@amd.com>, pbonzini@redhat.com,
        seanjc@google.com, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, joro@8bytes.org, thomas.lendacky@amd.com,
        x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        brijesh.singh@amd.com
Subject: Re: [PATCH v4 5/5] x86/kvm: Add guest support for detecting and
 enabling SEV Live Migration feature.
Message-ID: <YNZXPEPxv54UmzNj@zn.tnic>
References: <cover.1623421410.git.ashish.kalra@amd.com>
 <8c581834c77284d5b9465b3388f07fa100f9fc4e.1623421410.git.ashish.kalra@amd.com>
 <CABayD+ckOsM4+sab00SggrH3_iFaiV-7h9tHHuL1J-o6_YQVKA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CABayD+ckOsM4+sab00SggrH3_iFaiV-7h9tHHuL1J-o6_YQVKA@mail.gmail.com>
Precedence: bulk

On Fri, Jun 25, 2021 at 02:02:32PM -0700, Steve Rutherford wrote:
> Boris, do you have any thoughts on the kexec aspect of this change?

I'm suspecting you're asking here the wrong guy - I think you mean
Paolo.

But if I were to give some thoughts on this, I'd first request that this
patch be split because it is doing a bunch of things at once.

Then, I have no clue what "kexec support for SEV Live Migration" is. So
this whole use case would need a lot more detailed explanation of all
the moving parts and the "why" and the "because" and so on...

But I'm no virt guy so perhaps this all makes sense to virt folks.

Oh, and there's silly stuff like

+static int __init setup_efi_kvm_sev_migration(void)
{
	...
	return true;
}

returning a bool but that's minor.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette