Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210624121633.22179-2-rajan.vaja@xilinx.com>
References: <20210624121633.22179-1-rajan.vaja@xilinx.com> <20210624121633.22179-2-rajan.vaja@xilinx.com>
Subject: Re: [PATCH v5 1/4] clk: zynqmp: Use firmware specific common clock flags
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Rajan Vaja <rajan.vaja@xilinx.com>
To:     Rajan Vaja <rajan.vaja@xilinx.com>, kristo@kernel.org,
        lee.jones@linaro.org, michal.simek@xilinx.com,
        mturquette@baylibre.com, quanyang.wang@windriver.com
Date:   Fri, 25 Jun 2021 16:21:43 -0700
Message-ID: <162466330370.3259633.11293469583164120084@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Rajan Vaja (2021-06-24 05:16:30)
> diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
> index db8d0d7161ce..af06a195ec46 100644
> --- a/drivers/clk/zynqmp/clkc.c
> +++ b/drivers/clk/zynqmp/clkc.c
> @@ -271,6 +271,34 @@ static int zynqmp_pm_clock_get_topology(u32 clock_id=
, u32 index,
>         return ret;
>  }
> =20
> +unsigned long zynqmp_clk_map_common_ccf_flags(const u32 zynqmp_flag)
> +{
> +       unsigned long ccf_flag =3D 0;
> +
> +       if (zynqmp_flag & ZYNQMP_CLK_SET_RATE_GATE)
> +               ccf_flag |=3D CLK_SET_RATE_GATE;
> +       if (zynqmp_flag & ZYNQMP_CLK_SET_PARENT_GATE)
> +               ccf_flag |=3D CLK_SET_PARENT_GATE;
> +       if (zynqmp_flag & ZYNQMP_CLK_SET_RATE_PARENT)
> +               ccf_flag |=3D CLK_SET_RATE_PARENT;
> +       if (zynqmp_flag & ZYNQMP_CLK_IGNORE_UNUSED)
> +               ccf_flag |=3D CLK_IGNORE_UNUSED;
> +       if (zynqmp_flag & ZYNQMP_CLK_GET_RATE_NOCACHE)
> +               ccf_flag |=3D CLK_GET_RATE_NOCACHE;

Does the firmware really use all these flags? Ideally we get rid of the
above two.

> +       if (zynqmp_flag & ZYNQMP_CLK_SET_RATE_NO_REPARENT)
> +               ccf_flag |=3D CLK_SET_RATE_NO_REPARENT;
> +       if (zynqmp_flag & ZYNQMP_CLK_GET_ACCURACY_NOCACHE)
> +               ccf_flag |=3D CLK_GET_ACCURACY_NOCACHE;
> +       if (zynqmp_flag & ZYNQMP_CLK_RECALC_NEW_RATES)
> +               ccf_flag |=3D CLK_RECALC_NEW_RATES;

And this one.

> +       if (zynqmp_flag & ZYNQMP_CLK_SET_RATE_UNGATE)
> +               ccf_flag |=3D CLK_SET_RATE_UNGATE;
> +       if (zynqmp_flag & ZYNQMP_CLK_IS_CRITICAL)
> +               ccf_flag |=3D CLK_IS_CRITICAL;

And this one.

I worry that supporting all these flags will mean we can never get rid
of them. And we currently don't support setting critical via DT, which
is essentially another firmware interface like this one.

> +
> +       return ccf_flag;
> +}
> +
>  /**
>   * zynqmp_clk_register_fixed_factor() - Register fixed factor with the
>   *                                     clock framework