Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <YNRzFOIKtUZfnsu7@orome.fritz.box>
References: <20210624084737.42336-1-aardelean@deviqon.com> <YNRzFOIKtUZfnsu7@orome.fritz.box>
Subject: Re: [PATCH] clk: tegra: clk-tegra124-dfll-fcpu: don't use devm functions for regulator
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, pdeschrijver@nvidia.com,
        pgaikwad@nvidia.com, jonathanh@nvidia.com
To:     Alexandru Ardelean <aardelean@deviqon.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        mturquette@baylibre.com
Date:   Fri, 25 Jun 2021 16:23:20 -0700
Message-ID: <162466340054.3259633.8766268265703754283@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Thierry Reding (2021-06-24 04:57:08)
> On Thu, Jun 24, 2021 at 11:47:37AM +0300, Alexandru Ardelean wrote:
> > The purpose of the device-managed functions is to bind the life-time of=
 an
> > object to that of a parent device object.
> >=20
> > This is not the case for the 'vdd-cpu' regulator in this driver. A
> > reference is obtained via devm_regulator_get() and immediately released
> > with devm_regulator_put().
> >=20
> > In this case, the usage of devm_ functions is slightly excessive, as the
> > un-managed versions of these functions is a little cleaner (and slightly
> > more economical in terms of allocation).
> >=20
> > This change converts the devm_regulator_{get,put}() to
> > regulator_{get,put}() in the get_alignment_from_regulator() function of
> > this driver.
> >=20
> > Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> > ---
> >  drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> Indeed, this seems unnecessary:
>=20
> Reviewed-by: Thierry Reding <treding@nvidia.com>
>=20
> Mike, Stephen: do you want to pick this up directly or would you prefer
> if I collected this into a clk branch for the next cycle?
>=20

No worries. I got it.