Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1573049pxv; Fri, 25 Jun 2021 16:47:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfkd1mWQMZV6YmLpc0h/pnkRdYcx17TlfVcO2a0ng7lPSrke/RShME7VwKkt3bNZq4hul7 X-Received: by 2002:a17:907:1b1b:: with SMTP id mp27mr13258001ejc.538.1624664876434; Fri, 25 Jun 2021 16:47:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624664876; cv=none; d=google.com; s=arc-20160816; b=jEvLYxoHdXemF8UyrohkaZk+UZqRfD+pGx4ZdS57FQY3bWelrTFoVzz18apolQ978E 1zlB9b2W4Cf6ZfkDiffPI95t8hwWfiPmkX8/BO00eZ4QwmxBP9cDiy0yUvnIKRodlVGW G1FH9dOurQDIn6KyBTsiFPWSg8A9Z4lzxIsv7rXY08lMkORdCA3WzHlPGW6PfGjp3EPu TzUzhpnh4oxGf7xZjy7tafHcXMiI3qzTWtWB1uQ58QwhUxZmaz7oqNdXaojhNbT43x7t 0nclq0eJgmwkdsdttBekhsGDLjEKFjfpZnCo1NlOqh7hikoJjA4PSjNtlbsXl2JCiDWw aEgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=H8uBLw6ZFX6X9YzS5by0gFRyk2Emmeb1ekSUfvOFvoY=; b=UWnE1BH6/LyvF4wqlPawHOUoTKoMgB+zN39MIEzbmVemuylDtTNiN9mZcg+xUhXddk oGxo0K3GAkS426fU8HjhBJlrsY6A2nRhSSLd46ZeHEVKUQCP6HEYmWGgLqHzEz1rAjFz vAmAA6NiFnGPRJr4AQYtOtESDg8Wb2xo4fo2hx3b+C5ciohFbqlcE66LCTO2fY+dZwLM p5YCl0kqA6jZYIVNKxQbc8+kDcEaxED7pNfE8XwIYxhpR8dee+sulW+Is/QrEird/MQX eCetpW0RwyqhKvILJsy/vuMPL3BfctTdEHabwWBn1S70DSf7we0NIt8LL8v4tIin+cZw H94g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AvFKYZ+v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si7618252edv.519.2021.06.25.16.47.28; Fri, 25 Jun 2021 16:47:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AvFKYZ+v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbhFYXrg (ORCPT + 99 others); Fri, 25 Jun 2021 19:47:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhFYXrf (ORCPT ); Fri, 25 Jun 2021 19:47:35 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 283FDC061574 for ; Fri, 25 Jun 2021 16:45:13 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id u13so19114988lfk.2 for ; Fri, 25 Jun 2021 16:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H8uBLw6ZFX6X9YzS5by0gFRyk2Emmeb1ekSUfvOFvoY=; b=AvFKYZ+vzzHT9J7aUt5cEslmoFh+LU9rRwhqrE3rZxvKP3d+F4U3dmc5JVPn3qdrgb 1eBUs00jlFG45sEBGWT1QPWBGPw5L/8zR7DlZP7vUxCAmcjb9u0wiOkfWZu2dmcXU5+N +Qu6WTVXaal4wHpVzQczDvqaC+Liz/9WMyyyV3Sf3IBVn9bf+Sb/pe2bWRmkNbsiQHaF sKJlZEj5mos1s2RBgjUrcjAUOyeMfq33d+TVXbXSDRxj2dXEXksiyf3mM0AO8XSOXY8J JImrWV/+B0BrrYNih4UHZayeDPx3IGqAzOlZJPy1l6CKfntSO9kaAUAN5md5TLG+5lnW Wb+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H8uBLw6ZFX6X9YzS5by0gFRyk2Emmeb1ekSUfvOFvoY=; b=jOhO64R0gdsoBFIa8bvlgj+zMC35t4ikJ9b96+fbhnQJ3iUP20p53z8HnM92ThX8qr /HlN2PSPqwDoExVzOaLuoncBiSUT0i5p/3lahqBTZ7H140SvRRkfgSPLzLlctlDJ9UiE wy+3QSdYl3L3YTZVVOehx96cMP0VAUjrnYVTmsb9l0jstQelZDnlVjsmcWk/jL2+5HKO Dbgw+9OnNrntK03UxHjplHwsuWvB8iBrwSJPcQE/3dk279qaIQVm/DqWgk52CNLr5eLt 6Bu2T2cmoFNZIlwy96J6YatFu5rrw9CjPFfLgDkldh+8/gz9lFxRN8eUTQxzS4tupyLM CZYA== X-Gm-Message-State: AOAM530T2VyBfLovKQd8cfYShjezZkDW7ivol08m/32eSIdUtAVsWKCa Upfw3e+U7bXw8YNwdLCDyQm28UYJIBV/DcdpWl/tNg== X-Received: by 2002:a19:6e44:: with SMTP id q4mr9989361lfk.586.1624664711513; Fri, 25 Jun 2021 16:45:11 -0700 (PDT) MIME-Version: 1.0 References: <1624273214-66849-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: <1624273214-66849-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> From: Linus Walleij Date: Sat, 26 Jun 2021 01:44:59 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: zynqmp: some code cleanups To: Sai Krishna Potthuri Cc: Michal Simek , Linux ARM , linux-kernel , "open list:GPIO SUBSYSTEM" , git , saikrishna12468@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 1:01 PM Sai Krishna Potthuri wrote: > Some minor code cleanups and updates which includes > - Mention module name under help in Kconfig. > - Remove extra lines and duplicate Pin range checks. > - Replace 'return ret' with 'return 0' in success path. > - Copyright year update. > - use devm_pinctrl_register() instead pinctrl_register() in probe. > > Signed-off-by: Sai Krishna Potthuri I like these cleanups, so: patch applied! Yours, Linus Walleij