Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210622043329.392072-1-axel.lin@ingics.com> <20210625183935.17fae37f@coco.lan>
In-Reply-To: <20210625183935.17fae37f@coco.lan>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Sat, 26 Jun 2021 08:48:56 +0800
Message-ID: <CAFRkauBKCpp95yFEYsH6TEfzSWc--zqR8oLVkmdExmTOiVS-iw@mail.gmail.com>
Subject: Re: [PATCH] regulator: hi6421v600: Fix setting wrong driver_data
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> > -     mutex_init(&sreg->enable_mutex);
> > +     mutex_init(&priv->enable_mutex);
>
>
> > +     platform_set_drvdata(pdev, priv);
>
> This won't work, as platform data was already set, as it is already used
> as part of the MFD/SPMI binding logic. With the current

I think you mixed dev->platform_data with dev->driver_data.
Can you check again?

Regards,
Axel