Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1657956pxv; Fri, 25 Jun 2021 19:38:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOw5sQ65ViniX4AHVHUpHKCTcL1CY4hH7Qa3WAeaCNGeywDW48VoLaEdjR2KnoiruPCcUq X-Received: by 2002:a05:6402:354b:: with SMTP id f11mr18975780edd.387.1624675125812; Fri, 25 Jun 2021 19:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624675125; cv=none; d=google.com; s=arc-20160816; b=UZSWBSoY9ziPWQafS9O/aUWUqdHPC63N0ZUZEbT/72U2JcW3xAJvlI96dtmT4+2e9e BMZnCe9H1ZiHt7PPozkJx6Dg/zOF4wSmjCMYm15zz6XNj3LHUddIEm/I0mok0ggWBSMn 00M6oTdubBAFD0ujJCQuX6N0SO8Y3zcJ/PftQv/SPD9H3hnYe7h4YAyT7rMRAM/qi04b TbqGSmUt2Ix0j4dFehbMpHZM7Z2UOvdSAp35cr64nZiW5M3aBBT+zHwpivGGNnF2sf2+ MBFTDzF2I47Lr3UVoCynBx/I2Xkpq9jju6dMc5WtGnOFc+a5h+GD2UGzUB5MzGTgQD5s w3kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=//qyjLbcLV1pJ5kTBtwl/v0OtUjsJpx+Uypn9eCc8FI=; b=o7tyZHw4LnfRhZICTwLAo6KAHjCYxX0pW6sNuQO1n07wrHB9mesrvbeDGHYa9za5wQ U2cMxklWJE2VDyDPZC0GOzfUEPBr5RJT65xXW3Ikk5Evo6Erpz4lt86xZeDo/YULeu/I v6xfMg3Uub6OBSGMQTMewRiFlIQswWtkWUB0T88BCN39uI0rXUn8OiKQ30w3oz/1JXFC STlRY7Cqhaf2kUhAvTUdRk0s9gMPGRkww7ezBGJHhZUCOrOeWjofrGUsivspu5tO7BCH p/ziD2S4A0hYX9TOuNxbiHbyGMfEhJpKCIaJUPEGtI6+l2fAZRKVkmS86ngAqMf5PGY0 d7eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gz24si7246733ejc.418.2021.06.25.19.38.22; Fri, 25 Jun 2021 19:38:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbhFZCj4 (ORCPT + 99 others); Fri, 25 Jun 2021 22:39:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbhFZCjz (ORCPT ); Fri, 25 Jun 2021 22:39:55 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258ECC061574 for ; Fri, 25 Jun 2021 19:37:34 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwyCC-00CKWy-L1; Sat, 26 Jun 2021 02:37:24 +0000 Date: Sat, 26 Jun 2021 02:37:24 +0000 From: Al Viro To: Linus Torvalds Cc: Andrew Morton , Alexey Dobriyan , Linux Kernel Mailing List , Miguel Ojeda Subject: Re: [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT Message-ID: References: <20210625163040.a15af04872959da9af161fca@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2021 at 07:05:58PM -0700, Linus Torvalds wrote: > > Do we really care about userspace which relies upon an SVR4 quirk? I > > guess it's too hard to prove the no case, so it stays. > > I think we can safely remove it. Doing a mmap() at address zero will > not actually work anyway in any half-way modern Linux environment. > > And I think the "map zeroes at NULL" wasn't even universal for SVr4. > _Some_ binaries may have expected it, but I suspect it was the > exception rather than the rule. > > So I'd happily take a patch that just removes it. If nothing else, it > would be trivial to put back if somebody screams, but I seriously > doubt that is going to happen. Wasn't there some emulator (dosemu? wine?) that relied upon that? Said that, I could be easily wrong - half-asleep right now...