Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1678032pxv; Fri, 25 Jun 2021 20:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrGycT4/W/6DSgG7Nay5wTW8blL4p42DxoTC+XbTbv7Xs9B0zjz6k+QFLTtKdyhtgoyYEl X-Received: by 2002:a17:907:6e7:: with SMTP id yh7mr14572816ejb.352.1624677731173; Fri, 25 Jun 2021 20:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624677731; cv=none; d=google.com; s=arc-20160816; b=aczdJxgQjgRSQfYp8NGL8+NB7iu5HgLg5YVV5hyFzNqCgJhaWQZLsrUJASVt30JCsQ yurq6fIsDRMT+yYQY01yX90K5mknL5vD1I0+/GRs2jdlCjE0rZXX8/t4xmtnk3ZUYDOw NIHYIngWCzAI29xR/qO3k+ZuM6l8BgnXrDlcpHFDYB2lAH3I02StEsitkxBiaHEtn3A5 hd1qWRzoiSGQtFyg8x0gSrVEhFgRFGwaxIULou102Ff4yyIbA/xVLTHqfNH7QITj3Uey jwjg+XTvEKuukWJ9/w5pd7I3veAJVAWKjPiqFpidBU2NiZFg4MMC5c1+WHsirYZLj+2d 0lAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m/r2jKnf6mzXHGS0+mY6tO8kdxoIVifevnwrBMvWaHk=; b=R2On0pZyeHMc8COBZABrAi285kjMKZ2culhlgbGX89to7HSolxbjk+TqOoasJ3gvq9 2GUX7LvZer9mwb0AeRiwsKGZJFAhHXfQTqC2cbk8WYFqY6csGkpqvlljdcrVlJg1tfVR Po6aMYV+mJB+XypYA+60pmKNkiFYJS1NUEU6bBPJa6y/CxTeZl8qYY02tX0fBQbaHkp8 D+g6SoerycRmkyI/YlQ18wRB3M5bBbiE9aP1T6mMpNgQ6E4u/4i4pPoAsA/iEy4367Gv +Ie1APqJ0YAy3Q9wSf+J/8JmcmbhES9FUju6EsckiIm1tY2Wd1GXU4Ftbg7c9YcBVVeE nDow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=k5evDFcu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si2602793edd.72.2021.06.25.20.21.48; Fri, 25 Jun 2021 20:22:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=k5evDFcu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbhFZDWz (ORCPT + 99 others); Fri, 25 Jun 2021 23:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbhFZDWx (ORCPT ); Fri, 25 Jun 2021 23:22:53 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9E96C061574 for ; Fri, 25 Jun 2021 20:20:31 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id c7-20020a17090ad907b029016faeeab0ccso9098666pjv.4 for ; Fri, 25 Jun 2021 20:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m/r2jKnf6mzXHGS0+mY6tO8kdxoIVifevnwrBMvWaHk=; b=k5evDFcu122UMvrbb5kz6pJG46rSJobzAashV394QfzBP+VFZW1qcemLOWIMTqTwnO KhX0VgfKs97JSqirj7NxmKbJhyY7pwgk8AjhjA15rr2M34TyDxxbjmKofm2KW8+ZtL0q Wq8LJ8oNzBFS43JDygd5Msv1UzewtYzPIfmIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m/r2jKnf6mzXHGS0+mY6tO8kdxoIVifevnwrBMvWaHk=; b=AL+5f8lHhHdL7yT+nRWz77K3E/CEeuwqZKIJCS7DZ85RjCpseWJCo/58XF1ZoXi/mJ w5tlbq9x/hMm0CQIANdOpX2easihj91tc0Kw5p0iUMbysmKX1fxQRyMNtcZ/7PmcqILa EmOBddFQKSWf4zHOYd/AKmfsbSyQ5pn/tVisBCNAQ8T0Q7sX26VagVooH9AADxY9HPpv dLnbj2F3AZcGrbsGxl+Vv/9rh0OOJxUlEdkVb1IkkZIWmn4UWrzFbOuUeR1bRhoJe93N 0SxxiBHm3bKHOgDDqjq2S/jTa6VBQ8/VZE+YeJP8zlgrXgj1gM+h4+5ZWys4MOGGP9PP tJHg== X-Gm-Message-State: AOAM531YdAYRqzAJFD9ffiBLR4pU5/1DujXGfTAjl79DTq6e2ld8cXOK NP++aeJWmv/3rrp6M4OIvMlQmg== X-Received: by 2002:a17:90a:3d09:: with SMTP id h9mr23591717pjc.78.1624677631208; Fri, 25 Jun 2021 20:20:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h18sm6660549pgl.87.2021.06.25.20.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 20:20:30 -0700 (PDT) Date: Fri, 25 Jun 2021 20:20:29 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Linus Torvalds , Al Viro , Michael Schmitz , linux-arch , Jens Axboe , Oleg Nesterov , Linux Kernel Mailing List , Richard Henderson , Ivan Kokshaysky , Matt Turner , alpha , Geert Uytterhoeven , linux-m68k , Arnd Bergmann , Ley Foon Tan , Tejun Heo Subject: Re: [PATCH 3/9] signal/seccomp: Dump core when there is only one live thread Message-ID: <202106252018.0EC329C@keescook> References: <87a6njf0ia.fsf@disp2133> <87tulpbp19.fsf@disp2133> <87zgvgabw1.fsf@disp2133> <875yy3850g.fsf_-_@disp2133> <87lf6z6qbd.fsf_-_@disp2133> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf6z6qbd.fsf_-_@disp2133> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 02:00:22PM -0500, Eric W. Biederman wrote: > Replace get_nr_threads with atomic_read(¤t->signal->live) as > that is a more accurate number that is decremented sooner. Okay, seems fine to me. :) -- Kees Cook