Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1624640087.git.mchehab+huawei@kernel.org> <ef0ff659a875b91b454df12b57888f2b473877fa.1624640087.git.mchehab+huawei@kernel.org>
In-Reply-To: <ef0ff659a875b91b454df12b57888f2b473877fa.1624640087.git.mchehab+huawei@kernel.org>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Sat, 26 Jun 2021 11:41:50 +0800
Message-ID: <CAFRkauBcXDVihxN8MHoStGHjDyx-VyOe6tT8dkY2tAisHoeE8w@mail.gmail.com>
Subject: Re: [PATCH v9 2/5] regulator: hi6421v600-regulator: fix platform drvdata
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linuxarm@huawei.com, mauro.chehab@huawei.com,
        Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-staging@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> @@ -231,7 +228,7 @@ static int hi6421_spmi_regulator_probe(struct platform_device *pdev)
>  {
>         struct device *pmic_dev = pdev->dev.parent;
>         struct regulator_config config = { };
> -       struct hi6421_spmi_reg_priv *priv;
> +       struct hi6421_spmi_reg_info *sreg;
>         struct hi6421_spmi_reg_info *info;
>         struct device *dev = &pdev->dev;
>         struct hi6421_spmi_pmic *pmic;
> @@ -247,18 +244,17 @@ static int hi6421_spmi_regulator_probe(struct platform_device *pdev)
>         if (WARN_ON(!pmic))
>                 return -ENODEV;
>
> -       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> -       if (!priv)
> +       sreg = devm_kzalloc(dev, sizeof(*sreg), GFP_KERNEL);
> +       if (!sreg)
>                 return -ENOMEM;
>
> -       mutex_init(&priv->enable_mutex);
> -       platform_set_drvdata(pdev, priv);
> +       sreg->enable_mutex = &pmic->enable_mutex;
>
>         for (i = 0; i < ARRAY_SIZE(regulator_info); i++) {
>                 info = &regulator_info[i];
>
>                 config.dev = pdev->dev.parent;
> -               config.driver_data = info;
> +               config.driver_data = sreg;

This won't work and that was what my patch fixed.
e.g. When you call
struct hi6421_spmi_reg_info *sreg = rdev_get_drvdata(rdev);
sreg->eco_mode_mask and sreg->eco_uA will always be 0.

Regards,
Axel