Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] serial: amba-pl011: add RS485 support
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc:     Greg KH <gregkh@linuxfoundation.org>, linux@armlinux.org.uk,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210618145153.1906-1-LinoSanfilippo@gmx.de>
 <YNSA1H0cFKiPUn6N@kroah.com> <5d7a4351-2adc-ea31-3290-91d91bd5a5d4@gmx.de>
 <db436292-4115-0755-57d8-d63986f84453@kernel.org>
 <trinity-163a08b4-6e39-4d15-bde2-815342f13fc4-1624620116191@3c-app-gmx-bs05>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <a89dec92-e764-c833-bbeb-ba3d84381e78@kernel.org>
Date:   Sat, 26 Jun 2021 05:41:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <trinity-163a08b4-6e39-4d15-bde2-815342f13fc4-1624620116191@3c-app-gmx-bs05>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 25. 06. 21, 13:21, Lino Sanfilippo wrote:
> Thats right, the logic has slightly changed. I thought this does not matter as long as
> we make sure that exactly one of both ON_SEND or AFTER_SEND is set.

I actually don't know. But I would remain consistent with other drivers.

> We can stick with the logic
> in serial8250_em485_config() (i.e. always set ON_SEND and delete AFTER_SEND in case
> of an invalid setting), but I think this will require more than the four lines that we
> have now (especially if we want to avoid the !!).

What if you used only a single !?

thanks,
-- 
js
suse labs