Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 26 Jun 2021 10:21:13 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Jinchao Wang <wjc@cdjrlc.com>
Cc:     guillaume.tucker@collabora.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned
Message-ID: <20210626092113.GZ22278@shell.armlinux.org.uk>
References: <20210626065833.6653-1-wjc@cdjrlc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210626065833.6653-1-wjc@cdjrlc.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Sat, Jun 26, 2021 at 02:58:33PM +0800, Jinchao Wang wrote:
>   * By default, we write directly to secure registers.  Platforms must
>   * override this if they are running non-secure.
>   */
> -static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned reg)
> +static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned int reg)

... and then I'll get another patch because this now goes over 80
characters. No thanks.

There is nothing inherently wrong with "unsigned" - it's always been
legal C, and I'd prefer to keep the code as-is under arch/arm in
regard of this.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!