Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1903851pxv; Sat, 26 Jun 2021 03:57:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBKo4UddijQtnCVVrEBSLA1Mi4xoJww0wI8IOxIVXNpbO39fhWaVtOpdHYLRXB+XbWwUtT X-Received: by 2002:a05:6402:d66:: with SMTP id ec38mr21400596edb.212.1624705039035; Sat, 26 Jun 2021 03:57:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624705039; cv=none; d=google.com; s=arc-20160816; b=U5mG90tmXY2PVwwaUWCrZrVzTmUGa+3cox5U0e0pAo+wHC0INi3DlkuqhHmNaPZnaJ lNSme/3a5AwpLDEgfKqDNUH2rEba6UsYVh456UeHUcB2gxM3Y5rrQcrlvjNprUPbPpOR GBJPsOpDmbvqu+JVNmCcBAgn2HfD0USMDfgV4DiaQ2hD/PYeCDO4rE/DF0QVw7brmzPz etsVPaoZ3eOycmRDwcVujB7wqeQRSXvltrSPP/lsYU+snl9ReXW8Yg759fQO06NYjQcc Kd0srRHN96eq76lGCB5bxubZ2UA/DFSn605C2GF2VqhFhQvEcrFZSqAruSUv5UT+Imeg 0A2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=5IakmMrURhycOrgMfR07LYIjzM4DIOC86+dJLV+QXtE=; b=SU0KYe6MN+NHRAZYsVotzYpvMkumAk3kKlNufU8w5pVtGGo+3kr4zvimrob1xbOIvS wSFmrMOkucyK2DMPHNmqoRqVl7IjAxkwtHBGOJwy7s5J324Mj/vPFjKtdSYW0rH5P+gC KlqjLnaK34WVxUnqpJbpHoiiiEP0wGsuFa8GqRti4qBMfrtMPgxHLNtngYlN+f/kmDkP gEjtdL6SvGAS0cPRRnKQUQjOBvf5FNMesVPxITILy+melqcxAi/FaznF3kgcf3T2zx/j K71XtsgKiQit/GfNPp3WQONUJDQdIB1XIGIA/97kCat1gI+9+pqMtNjtMMZeXS9n3qn5 9hhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tJM12ZzF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si6182974edw.533.2021.06.26.03.56.53; Sat, 26 Jun 2021 03:57:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tJM12ZzF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229922AbhFZK4L (ORCPT + 99 others); Sat, 26 Jun 2021 06:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbhFZK4L (ORCPT ); Sat, 26 Jun 2021 06:56:11 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DFA3C061574; Sat, 26 Jun 2021 03:53:48 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id j6so6009826qvp.3; Sat, 26 Jun 2021 03:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5IakmMrURhycOrgMfR07LYIjzM4DIOC86+dJLV+QXtE=; b=tJM12ZzFZGep9dgrfo5utS8xjiFj8xNgXdKhGD3A9SmaJVv55z2dbAFR71Tbmn6Sea IygyNuEsD+k0js/M1w4rmHPEwGAIilhGD+DNFHa8L+iIXBZipBJ9EHHHqNYTIXeg4Fex 1EG9vUpbZN5Quo1q3/NZTu9X6LlyML8XgkDM1Ubf3CVPwWLHNe1HfkCnMVt449oWv9zB ei8oGQnjwQ3R4FpWQKR9KiXEY+NSGqxidKhNSsGscePbTanOWZrgBfdBgs9Ls2RuMv7Z qg7pkDppgBYjycxMvMR5DhVz7Fk/CB+AT5rvnP0oGp3kI/M7eHMhvJS8OX7yYZPQDhsr CAZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=5IakmMrURhycOrgMfR07LYIjzM4DIOC86+dJLV+QXtE=; b=fqwK3xMRHPj0p1gJUnEp7UPn3xII2DpJ6RCjPbUlqp0lb8Os9fTBcE70BTEOF2nNZu lKmtbB+6BgnAPV+9icpN82lBkZ96XFsfxDSFQ08ldXfyBKYMmC0eHtFmcb+ueAzqf8j/ yYkF4O73JLKZFCCZJs2q/5S5lSE0cxJcY/TjhFpB9XsNcY+90Jzs/Db2MCyz5UrYH1Rn ojOTIQjhqtovick9gM8A/2O19Noo+Hgr0DorHNQs0pejx7UCIj/XUc1t0MxiyGqKxXiL F9EuzoXaIvEeRgVck85ZdmZ5AogGokHo59l6CLcHtkBd/81z3srvOh27foo5fwmao0qz qHVQ== X-Gm-Message-State: AOAM532E/+c8Jxw/ano0SF0fIDY993JvDd8yaY7o9S3aeYWc3L/QnUg/ aiF1HVDj5riIIRoojlvjAis= X-Received: by 2002:a0c:f543:: with SMTP id p3mr12291007qvm.58.1624704827706; Sat, 26 Jun 2021 03:53:47 -0700 (PDT) Received: from localhost ([199.192.137.73]) by smtp.gmail.com with ESMTPSA id i3sm5365745qtp.2.2021.06.26.03.53.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Jun 2021 03:53:47 -0700 (PDT) Sender: Tejun Heo Date: Sat, 26 Jun 2021 06:53:45 -0400 From: Tejun Heo To: Waiman Long Cc: Zefan Li , Johannes Weiner , Jonathan Corbet , Shuah Khan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Roman Gushchin , Phil Auld , Peter Zijlstra , Juri Lelli Subject: Re: [PATCH v2 2/6] cgroup/cpuset: Clarify the use of invalid partition root Message-ID: References: <20210621184924.27493-1-longman@redhat.com> <20210621184924.27493-3-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621184924.27493-3-longman@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Waiman. On Mon, Jun 21, 2021 at 02:49:20PM -0400, Waiman Long wrote: > 1) A partition root can't be changed to member if it has child partition > roots. > 2) Removing CPUs from cpuset.cpus that causes it to become invalid is > not allowed. I'm not a fan of this approach. No matter what we have to be able to handle CPU removals which are user-iniated operations anyway, so I don't see why we're adding a different way of handling a different set of operations. Just handle them the same? Thanks. -- tejun