Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2013015pxv;
        Sat, 26 Jun 2021 06:54:24 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzy0hiSzDJ40PKr4hd0jjR7BK+p9sl5gVdMg7Hm7xYAqM2uth0TTCe3ybGPAybYIuJ6iRKC
X-Received: by 2002:a92:200b:: with SMTP id j11mr517622ile.183.1624715663999;
        Sat, 26 Jun 2021 06:54:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1624715663; cv=none;
        d=google.com; s=arc-20160816;
        b=O2IXXEjVfwvA0KdkwhSpa8DgHjj3Egu591ZiBWro0GMFHqYPI/IYdzLfgwBPlLJsvr
         9GpvLnGhSuDzav3K/7b8+OS0TVvan9NZ41bVt5ly7xk9JG5ErBJh+FrXgOIkx9VP0BkE
         AAluyBfYJadDRs9S0pA5to05fom2o4i56szIiAshsZbb9HywHLIZHO7lrVyG3d+HXYzb
         We3CmgNL3skB3LioB8T3AqHc960mej8hHwoJmugfJn0w69uiXfGduLXPqX2QbmcKtuf/
         yqWsbNPU7RfQ4V0vjUwqH83UM/9IqWhrGe6Z3ogWO1n5cGmarOGqfzF0zYgi8VjygCeX
         sa/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:mime-version
         :dkim-signature;
        bh=8BednVfZNPeXesyJxP0kndhNa6NZwGUlsHO3tLnUb1A=;
        b=mLje/4gvIPpYflIA+FKZ1ZyGvzuKTmOGSZfUIl3CnQNkTnXdiL0rIR3YpojzIZsNuq
         /W3mlo+xWP/bevMDedR6XebcmEinfkhUOqDOliPrGWqMyWt0YsUjjSoq++ev/8a4d8hb
         OcLhQcjvDmNwInKX5pdIHzQ7UMqSOpPDzDLGALKSUnEwZe07q0S4T+vzhLGnKxqXVOPO
         b1hDBzRIxH/ACBdXVgK3WLkm+vJIcdjupRsb4dhLv8+Zq6AnXACiYn3o3zBO3MjvWnYe
         lQ+8phM7xXC/dok1Cz4bp5L/Nl5xKmqrWUKXtbtmYVYJUrV+yuF8TcYX8AsqKAKgOYGM
         rR9w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@ingics-com.20150623.gappssmtp.com header.s=20150623 header.b=ot3Fem7N;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a6si11385445ilv.63.2021.06.26.06.54.05;
        Sat, 26 Jun 2021 06:54:23 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@ingics-com.20150623.gappssmtp.com header.s=20150623 header.b=ot3Fem7N;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230031AbhFZNxs (ORCPT <rfc822;magnus.damm@gmail.com>
        + 99 others); Sat, 26 Jun 2021 09:53:48 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53246 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229518AbhFZNxr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 26 Jun 2021 09:53:47 -0400
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15B25C061574
        for <linux-kernel@vger.kernel.org>; Sat, 26 Jun 2021 06:51:25 -0700 (PDT)
Received: by mail-ed1-x530.google.com with SMTP id q14so17520825eds.5
        for <linux-kernel@vger.kernel.org>; Sat, 26 Jun 2021 06:51:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ingics-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:from:date:message-id:subject:to:cc;
        bh=8BednVfZNPeXesyJxP0kndhNa6NZwGUlsHO3tLnUb1A=;
        b=ot3Fem7NQbFJhFb3Kk3hkgGHr3lDV/wmetr416ZWKTs4/2iF5aJOhbDyiWJmG/jthk
         2LtB3vx/rqzkvrDC3DSG26/0SqDVhsTZN35MxgxDvDU6J1MIFHRCRWV8EXPkSKemPYaa
         QmMgKceVX+hgxntM5yT+A/3Q0drcmBYBiqNnm+eCp1o9rUAUqD0o3kwYFXKIdJTYa+tJ
         Yv20fbYdTkM5AhmWHd8TsoHP2VlszCJTbTuqOGBJfbyjhBKsFg8P+aoXQ9SpwDAqi9Qh
         lPulys8Y0PeFjPIqH+AdCGY+s4HGWl84hct2sLt/wxQoaXMNhgeudHh3mq4liUAnDe1u
         FAHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
        bh=8BednVfZNPeXesyJxP0kndhNa6NZwGUlsHO3tLnUb1A=;
        b=NSOWFb4Oik85nS/Jh4pAXe/i3Lu7Qm+wvQFq7wnY6uTURvadrJGivHIqbO5pH/7qNk
         FO2v0J/LZHkLrJVD8kOdRDgybYlHE5bDBZGJEEe6F6dHUqtW4xXGoPh+CzLCrUemgcNT
         5C97EuMguR7MDKqIYcQfoVGo2YyRhzInPxkKMV21QFr7Fb/0h8PiDBbDPe5xAiMAi5SD
         XGMuhhi1bNwqma5LsgzYsJsS4ZUlwIX5zX+/k2yg9kQQUtW+REM6zMjxdHTroy6erVko
         k7rsLQiPCx98ESALj5AtOe69RGx7O3SGVsrEFVaFpzt8Rcjbmv7Cl8rIn24zD6+/3JsY
         0TLQ==
X-Gm-Message-State: AOAM531Yf1TDj/i4puJdJZUjXwuz7LFYoOW4ogUXYwOqnFEEt+0XEHzr
        LHiCl+/bO9Dc0KYMYWvSbxoXM7fE1vKbvdl6Dh1udQ==
X-Received: by 2002:aa7:ce0c:: with SMTP id d12mr21912731edv.49.1624715483533;
 Sat, 26 Jun 2021 06:51:23 -0700 (PDT)
MIME-Version: 1.0
From:   Axel Lin <axel.lin@ingics.com>
Date:   Sat, 26 Jun 2021 21:50:47 +0800
Message-ID: <CAFRkauB=0KwrJW19nJTTagdHhBR=V2R8YFWG3R3oVXt=rBRsqw@mail.gmail.com>
Subject: regulator: rtmv20: Wrong mask for strobe-polarity-high/vsync-polarity-high?
To:     ChiYuan Huang <cy_huang@richtek.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi ChiYuan,

In drivers/regulator/rtmv20-regulator.c

#define RTMV20_STROBEPOL_MASK   BIT(1)
#define RTMV20_VSYNPOL_MASK     BIT(1)

                { "richtek,strobe-polarity-high", 1, 0, 1, 1,
RTMV20_REG_LDCTRL2,
                        RTMV20_STROBEPOL_MASK },
                { "richtek,vsync-polarity-high", 1, 0, 1, 1, RTMV20_REG_LDCTRL2,
                        RTMV20_VSYNPOL_MASK },

Both "richtek,strobe-polarity-high" and "richtek,vsync-polarity-high"
read the same register with the same mask.
Looks like one of the register or mask definitions is wrong.
I think this needs to be double checked.

Regards,
Axel