Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 26 Jun 2021 23:34:01 +0000
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.ne@posteo.net>
To:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
        Ash Logan <ash@heyquark.com>,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.ne@posteo.net>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] powerpc: wii.dts: Expose the OTP on this platform
Message-ID: <YNe5aW55SrXFGKFV@latitude>
References: <20210519095044.4109-1-linkmauve@linkmauve.fr>
 <20210519095044.4109-4-linkmauve@linkmauve.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="AdirIyIEOXEflO+W"
Content-Disposition: inline
In-Reply-To: <20210519095044.4109-4-linkmauve@linkmauve.fr>
Precedence: bulk


--AdirIyIEOXEflO+W
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote:
> This can be used by the newly-added nintendo-otp nvmem module.
>=20
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> ---
>  arch/powerpc/boot/dts/wii.dts | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.dts
> index aaa381da1906..7837c4a3f09c 100644
> --- a/arch/powerpc/boot/dts/wii.dts
> +++ b/arch/powerpc/boot/dts/wii.dts
> @@ -219,6 +219,11 @@ control@d800100 {
>  			reg =3D <0x0d800100 0x300>;
>  		};
> =20
> +		otp@d8001ec {
> +			compatible =3D "nintendo,hollywood-otp";
> +			reg =3D <0x0d8001ec 0x8>;

The OTP registers overlap with the previous node, control@d800100.
Not sure what's the best way to structure the devicetree in this case,
maybe something roughly like the following (untested, unverified):

	control@d800100 {
		compatible =3D "nintendo,hollywood-control", "simple-mfd";
		reg =3D <0x0d800100 0x300>;
		ranges;

		otp@d8001ec {
			compatible =3D "nintendo,hollywood-otp";
			reg =3D <0x0d8001ec 0x8>;
		};
	};


Thanks,
Jonathan Neusch=C3=A4fer

--AdirIyIEOXEflO+W
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmDXuWkACgkQCDBEmo7z
X9tvzBAAhBVGIh0LX0XckUdyK/Mf844H2Sz6NoqeJvEeiEAgrqri2Lu+4fCoeXER
d8Ll/zsvx97oEN7D5zpJd8OkDTVAJm/Mi+wGxJpEoAA9YpcwUgy6u6iHOGDne0Ad
XObW1M5WEIoui+A520Rc4HWU8L18gAnGXS8gy8Ekh7SFkr7S+hQECo+x8ssLEX6d
pct1h4Z5kPHvj38nTmIzNUhi8WWPihvVvlE+zhrhR+FOpFFQTBPBqe950/1tGic6
qOpPa1eeuQIk7T9NDlF5a7i3eMoPwL9OMfz8i/jhb5ALM45trbEo/A09GD1kjtLE
fx1G86a4QidPN4ps64eMQbHgeE6ciI+nTtZl5ntXwFm+6N5lWxZRN52Kh0ibpUQK
F8oFj+2i3eNA+KjO12TD3ZKpAGQiZhTx4JIrGni6STRPnvYrNwSJ9TfpiEzs0wJ0
L6ZLMf/yLzoLyHqk8N6DvZmQN79ZbvvF6tqAHg0qX/EIbx1k7kLuqJ3gd1spOtsh
UE/3WQfqbZBxfFJIDewzCHtCWcFA22e1HSPgevKZXFL+fe2ePIiO4Q/c8MmXTY1P
bpLjTyaFDrZ1mG9K3x5PwHOlBI3uOmpCzSm9zIysu5rOKVQo96CaNGhkHUOAdJNK
MALu5woA7Chz0z4P9G7+pAuqOJBHzcqRaqLpdXZ/S0BHJibHLSQ=
=EH1y
-----END PGP SIGNATURE-----

--AdirIyIEOXEflO+W--