Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210626161819.30508-1-sergio.paracuellos@gmail.com>
 <CAHp75VfM-35tQMRh98mtg2XmDOJFnmjdYRKZZoi9ADm=AT2xUw@mail.gmail.com> <CAMhs-H_fcNDAOHm=tZB4ku9fzeea_7f4ZLg7w5KEmcNu+8wbQQ@mail.gmail.com>
In-Reply-To: <CAMhs-H_fcNDAOHm=tZB4ku9fzeea_7f4ZLg7w5KEmcNu+8wbQQ@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 27 Jun 2021 13:51:22 +0300
Message-ID: <CAHp75VeN+vww=Bj=g-nx9AT0FKSGAZ8CKQZn=ff2kfQWM+dxdw@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: mt7621: support gpio-line-names property
To:     Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        John Thomson <git@johnthomson.fastmail.com.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        NeilBrown <neil@brown.name>,
        =?UTF-8?Q?Ren=C3=A9_van_Dorst?= <opensource@vdorst.com>,
        Nicholas Mc Guire <hofrat@osadl.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jun 27, 2021 at 12:47 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
> On Sun, Jun 27, 2021 at 11:33 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Sat, Jun 26, 2021 at 7:18 PM Sergio Paracuellos
> > <sergio.paracuellos@gmail.com> wrote:
> > >
> > > The default handling of the gpio-line-names property by the
> > > gpiolib-of implementation does not work with the multiple
> > > gpiochip banks per device structure used by the gpio-mt7621
> > > driver.
> > >
> > > This commit adds driver level support for the device tree
> > > property so that GPIO lines can be assigned friendly names.

> > > This driver has three gpiochips with 32 gpios each. Core implementation
> >
> > implementation
> >
> >
> > > got gpio's repeated along each gpio chip if chip.names is not assigned.
> > > To avoid this behaviour driver will set this names as empty or
> >
> > the driver
> > these names
> >
> > > with desired friendly line names. Consider the following sample with
> > > minimal entries for the first chip with this patch changes applied:
> >
> > The same comment as per v1:
> >
> > Any idea why it's not a duplicate of
> > https://elixir.bootlin.com/linux/v5.13-rc7/C/ident/devprop_gpiochip_set_names,
> > and why the latter is not called in your case?
>
> The core properly calls this function but not in the way expected.
> This driver implements three banks of 32 gpios each internally using
> one gpiochip per bank, all of them in the same device. So the core
> code you are pointing out here duplicates the same names along the
> three gpiochips which is not the expected behaviour. So implementing
> in this way and setting names at least reserved avoids the core code
> to be run and also avoids the duplication getting expected behaviour
> for all the banks and each line friendly name.

Isn't it the problem of how we supply fwnode in that case?
Another possibility is to fix DT (although I'm not sure it's now possible).

Have you considered the above?

-- 
With Best Regards,
Andy Shevchenko