Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2746337pxv; Sun, 27 Jun 2021 07:34:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaSjAIQc5VDsgzC6GnfiSbJYTG+MfaqLnEXobVamUKLJy2nIuqQefZlfCWNMSJl81lpJtK X-Received: by 2002:a17:906:b254:: with SMTP id ce20mr20357093ejb.480.1624804457206; Sun, 27 Jun 2021 07:34:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624804457; cv=none; d=google.com; s=arc-20160816; b=yD4EN/U0StDt7PFVxT+nyfobrHnFOoh19fBBUBk3DLDaaG5v39IzZiDsiOAy0zadFP deY96yTVwILIk2UfcdKbOvgAD09LuZhFgaHphUBjwcM7IR7tJnUrjXBt0H3RLNGZ4FNS ZgsQQqwAcEkpOWjq0eyHEijowamY65MwdJeOj6MZPBGPndI8fwpA2Yi2oDvI2XThbhx1 4PrD0AUlLbfOZvVFNu+Zq2lg+/L4g/HiyxJ36zQTpYQfObJG65zkRQiATos8GD2aKXLh Z61pzyZ4UtxrRQ+FbrtTUbv0xxiwGD4Ic+bprxyLbTFjq9eYjTmDFbkmhuMDwxkfetAc qdcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=+bIKV5egMn8rA6UCDnmxVZ3Qyl5LyTVQb3g/kBNiJHk=; b=pg+EdTtB1NArYqe6NRjQtALK6YN69GCOEdkAcaUvO9E4C8Npjc0BBtMqnagClozfS3 cG+l+YSWo7VQHZN2YK+lwCwV9MoLH39DwbKApJUod5iGj+AoQCkBixDsa5vAa9aj5lq2 qMNm62jc8y4sOyGhODnC+7vnCPlHAvvq36qNuY4bDET280CCUGGT7a0fj/RXyRqoeRlH p0aB/rfADb7BzB5PzXYe5S0C+dxD4GCYYg7IH5wZeTiDPUJzU5bliIqXqHnW71Ja6qzS 4W29iCMr6kURe36OXnxVei9duWOoM/QWgFyymtDn333msPyaNT3+Qm9IcBbzo0V9E5Rn QmVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id og31si9463486ejc.48.2021.06.27.07.33.52; Sun, 27 Jun 2021 07:34:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbhF0OcS (ORCPT + 99 others); Sun, 27 Jun 2021 10:32:18 -0400 Received: from netrider.rowland.org ([192.131.102.5]:36113 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S231158AbhF0OcQ (ORCPT ); Sun, 27 Jun 2021 10:32:16 -0400 Received: (qmail 625995 invoked by uid 1000); 27 Jun 2021 10:29:52 -0400 Date: Sun, 27 Jun 2021 10:29:52 -0400 From: Alan Stern To: Igor Kononenko Cc: Felipe Balbi , Greg Kroah-Hartman , Jens Axboe , openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] fms: Add TOC/PMA/ATIP DVD-ROM capabilities Message-ID: <20210627142952.GE624763@rowland.harvard.edu> References: <20210626211820.107310-1-i.kononenko@yadro.com> <20210626211820.107310-4-i.kononenko@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210626211820.107310-4-i.kononenko@yadro.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 27, 2021 at 12:18:16AM +0300, Igor Kononenko wrote: > The DVD-ROM required the SCSI 6.25 READ TOC/PMA/ATIP Command formats: > * Response Format 0000b: Formatted TOC > * Response Format 0001b: Multi-session Information > (MMC-6 Specification). > > This patch adds an implementation of that described above formats. I will sum up the last four patches of this series by saying that they add features for emulating DVD-ROM and BD devices. Doing so increases the size of the f_mass_storage driver by a considerable amount and also adds a large amount of new material to Jens Axboe's include/uapi/linux/cdrom.h. Is any of this really needed? What usage scenarios require f_mass_storage to emulate a DVD-ROM that couldn't use f_tcm instead? Alan Stern