Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210625202348.24560-1-paskripkin@gmail.com>
In-Reply-To: <20210625202348.24560-1-paskripkin@gmail.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Sun, 27 Jun 2021 11:22:32 -0700
Message-ID: <CAM_iQpWtncQbhfkrBNCU3iMKYfYCvhKzxTwoo0WWtDKpKbMe3w@mail.gmail.com>
Subject: Re: [PATCH] net: sched: fix warning in tcindex_alloc_perfect_hash
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>,
        David Miller <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        syzbot+1071ad60cd7df39fdadb@syzkaller.appspotmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 25, 2021 at 1:23 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> Syzbot reported warning in tcindex_alloc_perfect_hash. The problem
> was in too big cp->hash, which triggers warning in kmalloc. Since
> cp->hash comes from userspace, there is no need to warn if value
> is not correct
>
> Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
> Reported-and-tested-by: syzbot+1071ad60cd7df39fdadb@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>

Looks reasonable.

Acked-by: Cong Wang <cong.wang@bytedance.com>

Thanks.