Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754743AbWKMOLz (ORCPT ); Mon, 13 Nov 2006 09:11:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754745AbWKMOLz (ORCPT ); Mon, 13 Nov 2006 09:11:55 -0500 Received: from ns.suse.de ([195.135.220.2]:53214 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1754743AbWKMOLy (ORCPT ); Mon, 13 Nov 2006 09:11:54 -0500 To: "Myaskouvskey, Artiom" Cc: , "Satt, Shai" Subject: Re: [PATCH 2.6.19-rc5-git2] EFI: mapping memory region of runtime services when using memmap kernel parameter References: From: Andi Kleen Date: 13 Nov 2006 15:11:52 +0100 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 560 Lines: 11 "Myaskouvskey, Artiom" writes: > > +extern int is_available_memory(efi_memory_desc_t * md); Never put externs into .c files The whole approach of including the run time services into the memory map seems bogus. How about ioremap()ing (or fixmaping) them on demand instead? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/