Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <075e07c40b99f93123051ef8833612bc88a55120.camel@perches.com>
Subject: Re: [PATCH 1/3] checkpatch: skip spacing tests on linker scripts
From:   Joe Perches <joe@perches.com>
To:     Jim Cromie <jim.cromie@gmail.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20210626034016.170306-2-jim.cromie@gmail.com>
References: <20210626034016.170306-1-jim.cromie@gmail.com>
         <20210626034016.170306-2-jim.cromie@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
MIME-Version: 1.0
Date:   Fri, 25 Jun 2021 21:15:09 -0700
User-Agent: Evolution 3.40.0-1 
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2021-06-25 at 21:40 -0600, Jim Cromie wrote:
> Before issuing a WARNING on spacing, exclude reports on linker
> scripts, which don't comport to C style rules.  skip_on_filename()
> skips on *.lds.h files, I think covering all cases.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2546,6 +2546,11 @@ sub get_raw_comment {
> ?	return $comment;
> ?}
> 
> +sub skip_on_filename {
> +	my $fname = shift;
> +	return $fname =~ m@\.lds\.h$@;
> +}

nak.  This is poor naming for what is not a generic function.

> @@ -5134,7 +5139,8 @@ sub process {
> ?							}
> ?						}
> ?					} elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
> -						if (ERROR("SPACING",
> +						if (!skip_on_filename($realfile) &&
> +						    ERROR("SPACING",
> ?							  "need consistent spacing around '$op' $at\n" . $hereptr)) {
> ?							$good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
> ?							if (defined $fix_elements[$n + 2]) {

This .lds.h test is also used in one other place.

It might be better to avoid all tests in .lds.h files by using a
"next if" much earlier.