Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "rogerq@kernel.org" <rogerq@kernel.org>,
        "a-govindraju@ti.com" <a-govindraju@ti.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kishon@ti.com" <kishon@ti.com>, Rahul Kumar <kurahul@cadence.com>,
        Sanket Parmar <sparmar@cadence.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdns3: Fixed incorrect gadget state
Thread-Topic: [PATCH] usb: cdns3: Fixed incorrect gadget state
Thread-Index: AQHXZ/3ptkUHEkmY6UucrnPuWW+DP6smAnGAgALJ+aA=
Date:   Mon, 28 Jun 2021 03:46:38 +0000
Message-ID: <BYAPR07MB53812E6619228B19C2C3A6DADD039@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20210623070247.46151-1-pawell@gli-login.cadence.com>
 <20210626085655.GA13671@Peter>
In-Reply-To: <20210626085655.GA13671@Peter>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mrZb1x8F7WV1xHkqBep3LbxFgbSXZEgG/B6qAQbb4cGMJAbr4T0CrInEOQ8y?=
 =?us-ascii?Q?8LwgMRPneZMX3fek4dSGQ3hQ2Yce1lBbgyCNyinyzwrQRvic1LttRPA7H51u?=
 =?us-ascii?Q?g9bLOp7bEgRANFe9OdFXByh+QZPKObjFI1pqsuzXowIQwbhrYcGn0tes8dIR?=
 =?us-ascii?Q?o4LrPzkikpYB2CX7wq4E2aZGA+9tyMKGZQTyvO+ZNI1mgZ5Iv1VvAuVzLIgD?=
 =?us-ascii?Q?IbgCpkEmr2rCknUJ3zpJEaBvb79O7jFTyO1mgpqHn4lO0yc2S7P3yXwBMSu7?=
 =?us-ascii?Q?w8VoZLTXVQcrOEXELWCwj4zYF0DOA+5ri7ttzlcppFlfikRogBMirrqgL+Ni?=
 =?us-ascii?Q?7Xv7/J/WMCFqQCOK+RP+dyINRH8E1+jg4KnP26g4iMOpOWzK2hbYvT1Jv53K?=
 =?us-ascii?Q?ZlOHOTBXa8/iY1GbJpY94zK+uMOt2X+1Gxitt9lhzxdsCvlEksIzsfaKCFDI?=
 =?us-ascii?Q?ZTzoDnmxkLWClc9zYCUxuODzGw2yhy1MwhEvfFw5tfjnLo8ZltSqbHrwsc8g?=
 =?us-ascii?Q?znbXGYxIKMOLrbHJPj90hV/7MTWoLFJMNlfC1uzdKPR6qpOOfYP+gGa1q5oO?=
 =?us-ascii?Q?uRuC8h9UsciI0CQb4iCa5bcxP4FnoKeCK4H5G7dsRw3vx5zqBh8S6iaf8k/b?=
 =?us-ascii?Q?1a0ropPwoluo2vLQP3bVI9Sk0JSmneNAwU3yXyZeAm1+YC/Ju/pvOsdBpH10?=
 =?us-ascii?Q?oz7sOmf8iyL1NMYK1uu5t5ychUT0H4scsyt/NnVjbw1jrjCmE4X4z3j2YdO4?=
 =?us-ascii?Q?/AVfifzGO87GK84ior1R59rZN7ZCpFSoXHDgUzFxhogTJuFQVuukgqplDF+Y?=
 =?us-ascii?Q?4IXB3qWxcjen5+ZnkUMr3hBQe5YNkUlKuWsujazw2mQhcY9DtrlfALxQIPJt?=
 =?us-ascii?Q?p3wEZHqLiFELhfVcYIVXvHhNayJy41gmku4YmspgoCXTSF3zcWTlXmXNa/uE?=
 =?us-ascii?Q?MXk0vN4dRH2EWkj4g/49hrsEThBX0lzXCcZBp3oQbl5FXRSqHv0vDA4+nuwG?=
 =?us-ascii?Q?uNt+8FqsD9WUlRo2OeabhNo9J37bcneq5lhU5FcO8cB5XP57HB7BOAPa+tkP?=
 =?us-ascii?Q?p7vJ9wj3DE62Q9wmXn6SWZBIQD21UoM1HbnKXV2lYIi07Iv7u+0+Q28anit7?=
 =?us-ascii?Q?9Zrd5uD1BZbATqHlCau7avBC9JTJaE6UeLdXWhXgAc0EvwyoAsUuLxsAi3ah?=
 =?us-ascii?Q?sPm3ruIO0x4m5SUkHK8yZMkTVeJ5EOvqL7nX/wr1xLwtCik3iHeGgmhp0MQc?=
 =?us-ascii?Q?fSY2t94bPZgJ+wSpmdIpHYHhql6KAsS2kJs+J8Pqm/GpCyQwm+1fbV4sFO7M?=
 =?us-ascii?Q?OsXTG1A8BqwOj3/zhmYHPV2+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd948225-317c-4450-5c2c-08d939e75597
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2021 03:46:38.4618
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YzmiFc1aOWTdY1pHX7S+R0BXW27+YG90vijg5yq0QiTsYr9MS0x6V8i3Czd4+saXat3vOde2UrFf5xEtsI0GFMQDiBYa1OxkDhGmZhtK8hA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR07MB8065
X-Proofpoint-ORIG-GUID: fpeW32o4bOcMBMSW1pqIDfYwe1cMykvj
X-Proofpoint-GUID: fpeW32o4bOcMBMSW1pqIDfYwe1cMykvj
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-06-28_03:2021-06-25,2021-06-28 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 adultscore=0
 malwarescore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0
 clxscore=1015 phishscore=0 priorityscore=1501 mlxlogscore=999
 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2104190000 definitions=main-2106280026
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On 21-06-23 09:02:47, Pawel Laszczak wrote:
>> From: Pawel Laszczak <pawell@cadence.com>
>>
>> For delayed status phase, the usb_gadget->state was set
>> to USB_STATE_ADDRESS and it has never been updated to
>> USB_STATE_CONFIGURED.
>> Patch updates the gadget state to correct USB_STATE_CONFIGURED.
>> As a result of this bug the controller was not able to enter to
>> Test Mode while using MSC function.
>
>Pawel, would you please describe more about this issue? I remember the cdn=
s3
>controller at i.mx series SoC could enter test mode by using current
>code.

The issue occurs only for MSC class. MSC class has delayed status stage, so
after returning from cdns3_req_ep0_set_configuration function called=20
for Set Configuration driver remains in USB_STATE_ADDRESS.

In order to enter to test mode driver needs meet the condition included in=
=20
cdns3_ep0_feature_handle_device function:
		if (state !=3D USB_STATE_CONFIGURED || speed > USB_SPEED_HIGH)
			return -EINVAL;

But it is still in USB_STATE_ADDRESS, because there was delayed status stag=
e.
To fix issue driver state must be updated to USB_STATE_CONFIGURED before=20
or after  finishing status stage.

>
>>
>> Cc: <stable@vger.kernel.org>
>> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/cdns3-ep0.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/cdns3/cdns3-ep0.c b/drivers/usb/cdns3/cdns3-ep0=
.c
>> index 9a17802275d5..ec5bfd8944c3 100644
>> --- a/drivers/usb/cdns3/cdns3-ep0.c
>> +++ b/drivers/usb/cdns3/cdns3-ep0.c
>> @@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep,
>>  		request->actual =3D 0;
>>  		priv_dev->status_completion_no_call =3D true;
>>  		priv_dev->pending_status_request =3D request;
>> +		usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED);
>>  		spin_unlock_irqrestore(&priv_dev->lock, flags);
>>
>>  		/*
>> --
>> 2.25.1
>>
>
--

Thanks,
Pawel Laszczak