Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3280052pxv; Mon, 28 Jun 2021 00:37:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV/yk3NCA0IBerCxx/UQXFWxhOTpdpxxzDXvbz7dWAo+1lS60FvG1RkM8MOSPbbIUzXdn8 X-Received: by 2002:a6b:7714:: with SMTP id n20mr19279460iom.126.1624865820288; Mon, 28 Jun 2021 00:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624865820; cv=none; d=google.com; s=arc-20160816; b=tMmADccVJvbTfXAhuucc+GH2nU0K4Q1Aa8+AR3g3f6fQ9iy+pDlLDtcewh8yv09LUf Q3TxKQfHuI55tCDUnD4GGtEVyCiSseqOj4b07RsY31TIjuMIKdrZMJLaRKn31prbL2CB 6kA/SIlruHzbYsP/yVTqMa0zmYd4aQapNAgQ3JSwG/3EsAwXYmm/1TH8jaYpK7j9GzPn rrD4Deg9DV1jChH1q7Q+1agZSbHLwE370E6MCAxOm/ZnRSc8CgV7+06UPHy8/ovMXl6e CfcWmxKPShBDCDpewBrycw1+27oJOErI7pVVmgSonI5hSa450pvFnDIUXxGtY1MUW5cg djKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=3eH7JntQIX6WDPF7n8CZ1FE82+sUKpSzL10RD2rH4lE=; b=kosRIbwt4bSIVX7eSg5dflo1zs6ma3JRo4AZfJQhbfz4jQwGo+38OmebrAzn//pckG hFCCZB4qj5ZRgHMBZOJnSP9g5VWSTD/41E17rl8uYJiQK2gR07+PI+cv/AKTGFFEIj0+ LfIZH1vduNWadr9j1XsF4Bm7asJA1DcBeqeD9T/3TfaM2IXHSVm0UxbpTPj4XNS7uwDR Fh7bv7jvtaqDKwmllyNSd3lf9KDUVRjLnouzOVrqx4vhnLirnvJeaDdpxGpQPlHHXe1Z 7sGWGZkUn81u0sH80wS25Lh/U4+ilyKCWus7mToEWyeQxMWXrPnkpd/ZbKYTz9WvQzEm jP2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=PRldYFsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t9si17702570jam.84.2021.06.28.00.36.48; Mon, 28 Jun 2021 00:37:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=PRldYFsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232413AbhF1Hhp (ORCPT + 99 others); Mon, 28 Jun 2021 03:37:45 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:52891 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232406AbhF1Hho (ORCPT ); Mon, 28 Jun 2021 03:37:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624865719; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=3eH7JntQIX6WDPF7n8CZ1FE82+sUKpSzL10RD2rH4lE=; b=PRldYFsxKjHKmxUgsT5Bd0P2ppNyn7vjKUk3aXYsIj7qL5sKuSqpv7nfdc2r+HjhIHKAHEaK HfEiFmH864KnGIXwOoBxSzksFs5+Bd+Vyfffw8W1fnPc0KdDngOJ9XRqFvpmRleMjmk0MQ8m gqzPUl1VBZvegd4C0GOP+6/Awfs= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60d97bb1d2559fe392700f4b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 28 Jun 2021 07:35:13 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 692A8C43217; Mon, 28 Jun 2021 07:35:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9871AC433F1; Mon, 28 Jun 2021 07:35:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 28 Jun 2021 15:35:12 +0800 From: Can Guo To: Bart Van Assche Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, ziqichen@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Jaegeuk Kim , Adrian Hunter , Kiwoong Kim , Satya Tangirala , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH v4 01/10] scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspended In-Reply-To: References: <1624433711-9339-1-git-send-email-cang@codeaurora.org> <1624433711-9339-2-git-send-email-cang@codeaurora.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-28 15:01, Can Guo wrote: > On 2021-06-25 07:42, Bart Van Assche wrote: >> On 6/23/21 12:35 AM, Can Guo wrote: >>> Rename pm_op_in_progress and is_sys_suspended to >>> wlu_pm_op_in_progress and >>> is_wlu_sys_suspended accordingly. >> >> Can the is_wlu_sys_suspended member variable be removed by checking >> dev->power.is_suspended where dev represents the WLUN? >> > > No, PM set dev->power.is_suspended to "false" even the device failed > resuming, > while is_wlu_sys_suspended can be used to tell that. FYI, 892 /** 893 * device_resume - Execute "resume" callbacks for given device. 894 * @dev: Device to handle. 895 * @state: PM transition of the system being carried out. 896 * @async: If true, the device is being resumed asynchronously. 897 */ 898 static int device_resume(struct device *dev, pm_message_t state, bool async) ... 967 End: 968 error = dpm_run_callback(callback, dev, state, info); 969 dev->power.is_suspended = false; ... Can Guo. > > Thanks, > > Can Guo. > >> Thanks, >> >> Bart.