Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Jun 2021 15:55:53 +0900
From:   Jung Daehwan <dh10.jung@samsung.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@intel.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: usb: host: Reduce xhci_handshake timeout in xhci_reset
Message-ID: <20210628065553.GA83203@ubuntu>
MIME-Version: 1.0
In-Reply-To: <YNlxzj7KXG43Uyrp@kroah.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----c2YBr1xbOYfB2IDqioM.uLYc5x244uDgwyTZAqanlpYp6BQp=_130472_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20210622113915epcas2p284c61291fc9d83487f6dfebb65fd4e9b@epcas2p2.samsung.com>
        <1624361096-41282-1-git-send-email-dh10.jung@samsung.com>
        <YNJAZDwuFmEoTJHe@kroah.com> <20210628022548.GA69289@ubuntu>
        <YNlxzj7KXG43Uyrp@kroah.com>
Precedence: bulk

------c2YBr1xbOYfB2IDqioM.uLYc5x244uDgwyTZAqanlpYp6BQp=_130472_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Mon, Jun 28, 2021 at 08:53:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 28, 2021 at 11:25:48AM +0900, Jung Daehwan wrote:
> > On Tue, Jun 22, 2021 at 09:56:20PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jun 22, 2021 at 08:24:56PM +0900, Daehwan Jung wrote:
> > > > It seems 10 secs timeout is too long in general case. A core would wait for
> > > > 10 secs without doing other task and it can be happended on every device.
> > >
> > > Only if the handshake does not come back sooner, right?
> >
> > Yes, right.
> >
> > > What is causing your device to timeout here?
> >
> > Host Controller doesn't respond handshake. I don't know why and I ask HW team
> > to debug it.
>
> Please work to fix your hardware, that feels like the root of the
> problem here.  If you require the timeout for xhci_reset() to happen,
> then how do you know that the hardware really did reset properly in the
> reduced amount of time you just provided?
>

I continue fixing this issue with hardware engineer, but currently just
host controller can crash whole system and that's why I want to fix it.
How about adding some error logs in this situation for recognizing this issue?
We can add error log in xhci_stop as xhci_reset can returns error like below.

static void xhci_stop(struct usb_hcd *hcd)
{
        u32 temp;
        struct xhci_hcd *xhci = hcd_to_xhci(hcd);
+       int ret;

        mutex_lock(&xhci->mutex);

@@ -733,6 +734,9 @@ static void xhci_stop(struct usb_hcd *hcd)
        xhci->cmd_ring_state = CMD_RING_STATE_STOPPED;
        xhci_halt(xhci);
        xhci_reset(xhci);
+       if (ret)
+               xhci_err(xhci, "%s: Error while reset xhci Host controller - ret = %d\n"
+                       , __func__, ret);
        spin_unlock_irq(&xhci->lock);


> thanks,
>
> greg k-h
>


------c2YBr1xbOYfB2IDqioM.uLYc5x244uDgwyTZAqanlpYp6BQp=_130472_
Content-Type: text/plain; charset="utf-8"


------c2YBr1xbOYfB2IDqioM.uLYc5x244uDgwyTZAqanlpYp6BQp=_130472_--