Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3302238pxv; Mon, 28 Jun 2021 01:14:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHsVlo21aLIC8YgGl6va9QovT1GWQVDalQ3XUmCiMMVmF+V4jOk5FRAOdZXogra2XrND8O X-Received: by 2002:a05:6e02:1a88:: with SMTP id k8mr12464235ilv.58.1624868044030; Mon, 28 Jun 2021 01:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624868044; cv=none; d=google.com; s=arc-20160816; b=VEWpmzeUYxKdYxUCtfyMwBjWpumlkH/0qeh+GyO3Jk+nGCZ15qjkGsW2uPLdrCZWSg IEhP8b8vTAGr1f1SB/3v/60BMasc6pcr6HTihQ/j8EadmS7zuhwvU4fhwjsVaDAQsg3L 1Ts0GTjAV6NvXjHe0kE2rNkCeoT0RhzF+RHPLtXsQ9mUkiv+AqV4vlK3UuNE9pokAfPd we30Cjxgcd2Pp1hIFzp3pbGGd6JtZ04xgOSDvOukdtHK8nj/v01iNtT1FKQa4e1WVjEt EoikrHG/Jxf2+jRyH/lOnlf19Xut4n5zdTOBzNbGG3SfQIqYOGRL9pBUpxb/J32pMJpW SamQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject; bh=CdICDM2ucR1ygY6zYdnfNbSQSpXNu8HYVTZI19uhShk=; b=HkeLB3DgxZ3jPEC8k3AuEN9Jb5uNSgCgceSV4CEQ2VqbEIk2hPAtgZTj6d1DA09Pc/ HRH83GoDTIIwA66Xjd8Lnd3fRLmlD2JnEpGSNVsm9sN1eaumwzFcz9Ra4pvi7WxY9J5B TV4dhvv0sejdqKkvFdv2OaLVELdfmcwPnDxZwVjfcnCtrfvcMEPswCRt0mhPBenO6dBq 1j8mIQcT4SRMpSWSt4CIglPgYz3zSImx4VMKFq5x8DLSirwR4ImbyTL+Grlaem8gDFgy 2ehUJWsqbVrDBvlfouhgDWCa+cBKPK+XUmfc67BcVYHGgncXolbIp2BIC6l0iJnaz3WM 5AGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q44si14224036jav.16.2021.06.28.01.13.52; Mon, 28 Jun 2021 01:14:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232405AbhF1IOO (ORCPT + 99 others); Mon, 28 Jun 2021 04:14:14 -0400 Received: from mga09.intel.com ([134.134.136.24]:60152 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232317AbhF1IOD (ORCPT ); Mon, 28 Jun 2021 04:14:03 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10028"; a="207851469" X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="207851469" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 01:11:31 -0700 X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="456227756" Received: from abaydur-mobl1.ccr.corp.intel.com (HELO [10.249.227.26]) ([10.249.227.26]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 01:11:28 -0700 Subject: Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel , Andi Kleen , Adrian Hunter , Alexander Antonov , Alexei Budankov , Riccardo Mancini References: From: "Bayduraev, Alexey V" Organization: Intel Corporation Message-ID: <8b738198-c77e-e35e-2bc8-f709d8ec937f@linux.intel.com> Date: Mon, 28 Jun 2021 11:11:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 27.06.2021 3:46, Namhyung Kim wrote: > Hello, > > On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev > wrote: >> >> Changes in v7: >> - fixed possible crash after out_free_threads label >> - added missing pthread_attr_destroy() call >> - added check of correctness of user masks >> - fixed zsts_data finalization >> [SNIP] > Thanks for your work, mostly looks good now. > > I have a question, where are the synthesized records saved? > Is it the data.0 file? Thanks for the review. As I understand the synthesized records (as well as other user-space records) are saved to perf.data/data, kernel records are saved to perf.data/data. Regards, Alexey > > Thanks, > Namhyung > > >> >> tools/include/linux/bitmap.h | 11 + >> tools/lib/api/fd/array.c | 17 + >> tools/lib/api/fd/array.h | 1 + >> tools/lib/bitmap.c | 14 + >> tools/perf/Documentation/perf-record.txt | 30 + >> tools/perf/builtin-inject.c | 3 +- >> tools/perf/builtin-record.c | 1094 ++++++++++++++++++++-- >> tools/perf/util/evlist.c | 16 + >> tools/perf/util/evlist.h | 1 + >> tools/perf/util/mmap.c | 6 + >> tools/perf/util/mmap.h | 6 + >> tools/perf/util/ordered-events.h | 1 + >> tools/perf/util/record.h | 2 + >> tools/perf/util/session.c | 500 +++++++--- >> tools/perf/util/session.h | 5 + >> tools/perf/util/tool.h | 3 +- >> 16 files changed, 1508 insertions(+), 202 deletions(-) >> >> -- >> 2.19.0 >>