Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Jun 2021 10:11:35 +0200
From:   Daniel Wagner <wagi@monom.org>
To:     Mike Galbraith <efault@gmx.de>
Cc:     John Kacur <jkacur@redhat.com>,
        RT <linux-rt-users@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Clark Williams <williams@redhat.com>,
        Daniel Wagner <dwagner@suse.de>,
        Johnathan Schwender <schwenderjonathan@gmail.com>,
        Peter Xu <peterx@redhat.com>
Subject: Re: [ANNOUNCE] rt-tests-2.0
Message-ID: <20210628081135.l7yvya7iaygb23ye@beryllium.lan>
References: <20210625160801.9283-1-jkacur@redhat.com>
 <549a4a5579068b9b1ca7741cb0f4aafbd04f4389.camel@gmx.de>
 <1c1966dd51ae6f8ddcd892cba485c332281fbd37.camel@gmx.de>
 <3d6a6c593eed6f5d59209ba2d8db29fadcc72ad7.camel@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3d6a6c593eed6f5d59209ba2d8db29fadcc72ad7.camel@gmx.de>
Precedence: bulk

Hi Mike,

On Sat, Jun 26, 2021 at 02:45:27PM +0200, Mike Galbraith wrote:
> On Sat, 2021-06-26 at 13:47 +0200, Mike Galbraith wrote:
> > On Sat, 2021-06-26 at 08:55 +0200, Mike Galbraith wrote:
> > > On Fri, 2021-06-25 at 12:08 -0400, John Kacur wrote:
> > > > I'm pleased to announce rt-tests-2.0
> > >
> > > Greetings,
> > >
> > > cyclictest seems to have grown an mlock related regression.
> >
> > Ok, chores done, I did a quick bisect/confirm.  I didn't go stare
> > at rt_test_start() to ponder what the mlockall connection may be.
>
> Moving the call above "Get current time" stops it mucking things up.

Thanks a lot for your excellent report. rt_test_start does

  static char ts_start[MAX_TS_SIZE];

  static void get_timestamp(char *tsbuf)
  {
          struct timeval tv;
          struct tm *tm;
          time_t t;

          gettimeofday(&tv, NULL);
          t = tv.tv_sec;
          tm = localtime(&t);
          /* RFC 2822-compliant date format */
          strftime(tsbuf, MAX_TS_SIZE, "%a, %d %b %Y %T %z", tm);
  }

  void rt_test_start(void)
  {
          get_timestamp(ts_start);
  }

I'd say the tsbuf access is the one which triggers a pagefault.

John, I would suggest to move the rt_test_start() into rt_init() and
take the timestamp at the execution start (as my initial version was). I
think the additional pain in slightly more correct start timestamp
(which is also not defined what it actually means in this context) is
just not worth the effort.

Thanks,
Daniel