Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3317832pxv; Mon, 28 Jun 2021 01:42:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXSStMGH3H0ywzwnafhNEG+hJndm8CpM9Fax5DknyRHXOdyPx93drwzWVazTf5QMQuQFp3 X-Received: by 2002:a92:da86:: with SMTP id u6mr17378599iln.215.1624869722642; Mon, 28 Jun 2021 01:42:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624869722; cv=none; d=google.com; s=arc-20160816; b=WcRGvjoYuJCNEZAY3AVJntYWHojqPhRkztlg5aoMe/IbXwJnGMrjCke3+qV+mvxTmv wNKD+AdP7lwNhgJnCAlsihMv2tVoCxf1L0sE1sDEGDMzh6A4A2ja9Gctb2CJDWFBImP4 /l75D6SyE064zqJLfXiKct+DKT6W5m+yJuh8TA3/YokmC/lp02dpGCAJUhO/nVRjrnLe 5jBYBV+dbBoW3exz0VcxESInxrvhsCfwBcKO7TmZocfON/21RXobIiiJ9N7+B/1csD37 Ur1LoTHT4WxP5adsXAJbW3+KhCh/ocxdgjjL+pS2zEiDUS1KGvfkzbACByA61RN6sYmY Zttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bBOOAJZmb1MGQkBOhTr3Y7C4iASxBA5CQqatO8OKvkU=; b=MT14ZRiJCHyHkZYce2AGDu9OjLBc7Qe5qDPo4lRg1D3r5bb/qUiMrR+/G4m/swfmDY guYgvtaxOWDFA2F2cmW1+rZintM2ck0ghzPqwQtjmNWPAnSvwKoriyNEHPfEEqXXxEmI g8fVcNfpiNF4V1ui+0Jqj+euUhdi11vVZsM5t8q9o5TC1QvqDxk0dT70ir+OJDVueCXE wJ4d8Z2jQ7DqQKy/SH+kwrhNqU57SwzMxYpFlJgORAxoGFitGAaZvVHY/U3WINi9SgSt OzkpA+t3SfMRoa325KSsUksGdb5+iPnusJK9ReQsyyOOfkXLLOfjVB3BxBuQXA6mZKTh aurw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="IcEY+/vJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si18650396ioo.53.2021.06.28.01.41.49; Mon, 28 Jun 2021 01:42:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="IcEY+/vJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232308AbhF1I2B (ORCPT + 99 others); Mon, 28 Jun 2021 04:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231698AbhF1I2B (ORCPT ); Mon, 28 Jun 2021 04:28:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D56C5C061574 for ; Mon, 28 Jun 2021 01:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bBOOAJZmb1MGQkBOhTr3Y7C4iASxBA5CQqatO8OKvkU=; b=IcEY+/vJyPW5mfpsonXxEzgnK2 ij2cjBwdvkFvDpKT0mwZmUi1tZbHxGz0K4oI6cmwke1DT62/JaCr7pB6BSOLJAX1D/tVjkOouDAOR azyo8Erh9WYzCWTBPA7tNyhFRwvALHIAwddq2XtH94udA/1OcPY+W6OwLOfPjAV86OITTrXfG/mfp f2mTpaPvkdIFLmqb5I1jwTQ0gHno895wsth7lUaQNgsIMXPfLVM14Fk/NNripoW65fF0QCMRHM7Ak D6jD95Cp7/u1V+FHmN+Zx7zV4G8Q4XH4sh4RM3FOip4LOEISeGUE+mMO3bv1GAObXLcgGJH/1pNc3 +zD31TVQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxmZL-002k7t-Ll; Mon, 28 Jun 2021 08:24:51 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 00C153001DC; Mon, 28 Jun 2021 10:24:39 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D71FF2028DBF2; Mon, 28 Jun 2021 10:24:38 +0200 (CEST) Date: Mon, 28 Jun 2021 10:24:38 +0200 From: Peter Zijlstra To: Michael Forney Cc: Josh Poimboeuf , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] objtool: Check for gelf_update_rel[a] failures Message-ID: References: <20210509000103.11008-1-mforney@mforney.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 12:52:07AM -0700, Michael Forney wrote: > On 2021-05-08, Michael Forney wrote: > > Otherwise, if these fail we end up with garbage data in the > > .rela.orc_unwind_ip section, leading to errors like > > > > ld: fs/squashfs/namei.o: bad reloc symbol index (0x7f16 >= 0x12) for > > offset 0x7f16d5c82cc8 in section `.orc_unwind_ip' > > > > Signed-off-by: Michael Forney > > Ping on these patches. Josh, I forever forget which libelf versions we're supposed to support, But these patches do look reasonable to me, wdyt?