Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3348144pxv; Mon, 28 Jun 2021 02:34:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4Ty4bLJQP4gOOPFH8PSROa35ktb0k0SsxgY40CQWnfuiPBUWVu4UftRsU7rEmqxWSbVML X-Received: by 2002:a05:6402:2749:: with SMTP id z9mr10154836edd.300.1624872871587; Mon, 28 Jun 2021 02:34:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624872871; cv=none; d=google.com; s=arc-20160816; b=FqkieYmaxSdBF3QMoXz/G04ylbIThHrDyefN7XYFhHvkBN32tqocN8b55y5E2FXktW Im64JZXG9Fs+saK0RX1b3hGPBnsk6w/jaR1XMmY2lYQK6q35e+Y7VAwafYhpmZKlEVpA pbww5GST5qCrZ2U0v+kT4RSJkE4neLGAtquXVPaCv/ezzduRW+y3f9pLtx6S76aeXqxb QcFqPJup1qQh8eEX9Iu42NfXALQWeqytp+wu8UY+OpAQGYYHK9Gi9KhURde6nx/x9QBL Fy1eYz4bSyP0thOvhAFcWzW2Qsc8/se6o00GCx/Qofzmu+UNyEdwRnXs2q6b50f0N+8T 3c7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=geRENDYPimHgjEK82Mv5XFsRe6Hfv859NmfgaH+ckRU=; b=LV3ZoFXvy6y7/itHTi2KnbJGU5QzPBA8UvXqp/1fSNecMUt2w/1DjxtU91hdjUwxQF YoHCLM/bhyzIi2XzEkQ/499NY6VqXXto2hc8GqFSNR5X8rFZyWXGncM2m0B2lbyJgjxy xZdffD0QHhK3pOfCi3r78vDwmgkTxuYdijDWlYvwyAFGyIgUhmOA2qQp9H9zal9LWUcd h5snsk7Fe0dUI7ksbjvdpP5HlYy6Bx5SHutLyHnJmGOPKpS6csoxaILntvIm3rrNin1q 2XHRZUUs/uJpXxlfAVosuNPjOIbDcLkrGnOaGfimi7XRNIoYnjinEG65nA9U+YZ/dajl DWBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mdirt+wh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 1si13769643ejm.532.2021.06.28.02.34.07; Mon, 28 Jun 2021 02:34:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mdirt+wh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232568AbhF1JdL (ORCPT + 99 others); Mon, 28 Jun 2021 05:33:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:32900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232426AbhF1JdL (ORCPT ); Mon, 28 Jun 2021 05:33:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D96461C5A; Mon, 28 Jun 2021 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624872646; bh=tko4HhpTn1KfqSQcG6rk256TdCkSHRTiZNDg1gfOL1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mdirt+wh3MtaZ7eNyZ9G3nbYCW5idUpb0uLyW3y3Pff8g1i8FeRt120hCx8rMfLOA LnRoyQZ6znqLxXb5WQ4POqk3nvJJlxgEnyIMLyf/4xRDnJ3jrCYholI79Dx7JQswRh BPPsck43uFy1epGSrPj0zjj0CnIzhGXT51/oNF84= Date: Mon, 28 Jun 2021 11:30:41 +0200 From: Greg KH To: Rocco Yue Cc: "David S . Miller" , Jakub Kicinski , Jonathan Corbet , Hideaki YOSHIFUJI , David Ahern , Matthias Brugger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, wsd_upstream@mediatek.com, chao.song@mediatek.com, kuohong.wang@mediatek.com Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Message-ID: References: <20210628071829.14925-1-rocco.yue@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210628071829.14925-1-rocco.yue@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 03:18:30PM +0800, Rocco Yue wrote: > On Thu, 2021-06-24 at 18:51 +0200, Greg KH wrote: > On Thu, Jun 24, 2021 at 11:55:02PM +0800, Rocco Yue wrote: > >> On Thu, 2021-06-24 at 14:23 +0200, Greg KH wrote: > >> On Thu, Jun 24, 2021 at 07:53:49PM +0800, Rocco Yue wrote: > >>> > >>> not have exports that no one uses. Please add the driver to this patch > >>> series when you resend it. > >>> > >> > >> I've just took a look at what the Linux staging tree is. It looks like > >> a good choice for the current ccmni driver. > >> > >> honstly, If I simply upload the relevant driver code B that calls > >> A (e.g. ccmni_rx_push), there is still a lack of code to call B. > >> This seems to be a continuty problem, unless all drivers codes are > >> uploaded (e.g. power on modem, get hardware status, complete tx/rx flow). > > > > Great, send it all! Why is it different modules, it's only for one > > chunk of hardware, no need to split it up into tiny pieces. That way > > only causes it to be more code overall. > > > >> > >> Thanks~ > >> > >> Can I resend patch set as follows: > >> (1) supplement the details of pureip for patch 1/4; > >> (2) the document of ccmni.rst still live in the Documentation/... > >> (3) modify ccmni and move it into the drivers/staging/... > > > > for drivers/staging/ the code needs to be "self contained" in that it > > does not require adding anything outside of the directory for it. > > > > If you still require this core networking change, that needs to be > > accepted first by the networking developers and maintainers. > > > > thanks, > > > > greg k-h > > > > Hi Greg, > > I am grateful for your help. > > Both ccmni change and networking changes are needed, because as far > as I know, usually a device type should have at least one device to > use it, and pureip is what the ccmni driver needs, so I uploaded the > networking change and ccmni driver together; > > Since MTK’s modem driver has a large amount of code and strong code > coupling, it takes some time to clean up them. At this stage, it may > be difficult to upstream all the codes together. Why? Just dump the whole thing in a drivers/staging/mtk/ directory structure and all should be fine. > During this period, even if ccmni is incomplete, can I put the ccmni > driver initial code in the driver/staging first ? After that, we will > gradually implement more functions of ccmni in the staging tree, and > we can also gradually sort out and clean up modem driver in the staging. I do not know, let's see the code first. But we can not add frameworks with no in-kernel users, as that does not make any sense at all. > In addition, due to the requirements of GKI 2.0, That is a Google requirement, not a kernel.org requirement. Please work with Google if you have questions/issues about that, there is NOTHING we can do about that here in the community for obvious reasons. > if ccmni device > uses RAWIP or NONE, it will hit ipv6 issue; and if ccmni uses > a device type other than PUREIP/RAWIP/NONE, there will be tethering > ebpf offload or clat ebpf offload can not work problems. > > I hope PUREIP and ccmni can be accepted by the Linux community. As I stated before you need to have an in-kernel user for us to be able to accept frameworks and functions into the tree. Otherwise Linux would quickly become unmanagable and unmaintainable. Would you want to try to maintain code with no in-tree users? What would you do if you were in our position? But for networking flags like this that go into userspace, I do not know what the maintainers of the networking stack require, so that really is up to them, not me. thanks, greg k-h