Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 28 Jun 2021 12:12:05 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Jonathan Liu <net147@gmail.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Sandy Huang <hjc@rock-chips.com>,
        Heiko Stubner <heiko@sntech.de>,
        Yannick Fertre <yannick.fertre@st.com>,
        Philippe Cornu <philippe.cornu@st.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Vincent Abriou <vincent.abriou@st.com>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        Jonas Karlman <jonas@kwiboo.se>,
        Sam Ravnborg <sam@ravnborg.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe
Message-ID: <20210628101205.bul2iwwljxtd24tb@gilmour>
References: <20210203091306.140518-1-jagan@amarulasolutions.com>
 <CANwerB1Bev8Ljta9OyO6vAKsQqHHmaJnjV1YRGmY4bVk_J6xZA@mail.gmail.com>
 <CAMty3ZAY7Ez9UYvfftSmqLEVWgN7xE5HevqfWirmrExZH=RMWA@mail.gmail.com>
 <CANwerB1AiiT3oXCpwP83M1=ES9M-yQoLuZO5f=eVxA42MkEbiA@mail.gmail.com>
 <YNR/uQrS75s5BILs@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pxsrq5bk7iavnx3y"
Content-Disposition: inline
In-Reply-To: <YNR/uQrS75s5BILs@pendragon.ideasonboard.com>
Precedence: bulk


--pxsrq5bk7iavnx3y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Jun 24, 2021 at 03:51:05PM +0300, Laurent Pinchart wrote:
> CC'ing Maxime Ripard.
>=20
> Maxime, is this similar to the issue we've recently discussed with the
> VC4 DSI encoder ?
>=20
> On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote:
> > On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote:
> > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote:
> > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote:
> > > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device=
 *pdev,
> > > > >         dw_mipi_dsi_debugfs_init(dsi);
> > > > >         pm_runtime_enable(dev);
> > > > >
> > > > > +       ret =3D drm_of_find_panel_or_bridge(dev->of_node, 1, 0,
> > > > > +                                         &panel, &bridge);
> > > > > +       if (ret)
> > > > > +               return ERR_PTR(ret);
> > > >
> > > > On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be
> > > > called again and result in the following errors:
> > > > [    0.717589] debugfs: Directory 'ff960000.mipi' with parent '/' a=
lready present!
> > > > [    0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create=
 debugfs root
> > > > [    0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_ru=
ntime_enable!
> > >
> > > Is this when you test bridge on rk3399 or panel?
> >=20
> > MIPI-DSI to LVDS bridge.

It looks more like a driver that doesn't free its resources properly on EPR=
OBE_DEFER?

Maxime

--pxsrq5bk7iavnx3y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYNmgdQAKCRDj7w1vZxhR
xR8DAP94cJXuHL0Y5IP7BYZbO+0AfSWavVR1bJBD81CtyTet5AEAzxOwqJgZ0od3
0W8wv1CYlqMx3P/bxlmTi9qwOAuJIwU=
=kLbL
-----END PGP SIGNATURE-----

--pxsrq5bk7iavnx3y--