Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3398282pxv; Mon, 28 Jun 2021 03:47:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDl59GqsrubkbDn5FOF8CiVqYtSd6B7L8LMcYU2rGXqcah3ndB8QkP2y3RHu4AreDZQX0r X-Received: by 2002:aa7:c301:: with SMTP id l1mr31892910edq.215.1624877256035; Mon, 28 Jun 2021 03:47:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624877256; cv=none; d=google.com; s=arc-20160816; b=E+oMyWpguhtRjd3vWCxZ/HiCK0TmZVi6gvmuRPtOpufh5cR/oUs0pWmzcn11sVU3nN retUvQ68ksMZD2TdAic0+zhLhQHx2TY9ye1wjcI9jKz4ec0rK1L/5bqd3gftaNbd4nfN hOShHPFb/uEjMPY3gYDxM7NMzXpAQtczd20EXIzOv8HLrlmMUVtpyicRCP3oonAy/Jif pgw7GZ6V7xqA4hTHzUd2BSResp7SSRc3UF8sxKK27BwZMMrRZ3WcO73Ph7SEINqwa0OM 9gocEDPAVcLZycpMSSsta5XNwFMXmiShUEjHjYCE+You0RwHk41F+e77/T6OqpD0y8zo 8mqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=A2agoC6sLRhWE9keKUCQElnqL0CvE3vVL5dLxu90aPE=; b=dDc7/eVPHwXJfpmoUSw1rmfnnviDBnXWdZLJTxp1c5Uxn2r+ljteZNth/Hlz9Quhjg cczI9X5zx1FAo/Fwcp63Jx14Pgo+cK5cFWD4tlSZlzm4RIneObeD1CgUfD20+ZDMt37f ks65tr0kNAeRSriYw7SMTzO8+3fapOWjpRNuQa4eirfqgD5KWeMYjMsrGucVLt2f4dWH paKC8cFHrVA8MxgrTqLEwyxrWcdqMkIGY9ir/2iSd6Ii/wlLH+XUFy93m6TfaSITVrBP P5PjsROyPwveCKr6T+/o23jcGnxSM/D1ILptrlrRWVjUubooxcxpoP3HYPhFqiD4Gb1J LinQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QvaSM22D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e18si13358960ejy.671.2021.06.28.03.47.11; Mon, 28 Jun 2021 03:47:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QvaSM22D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232782AbhF1Kr3 (ORCPT + 99 others); Mon, 28 Jun 2021 06:47:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29279 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232807AbhF1KrR (ORCPT ); Mon, 28 Jun 2021 06:47:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624877092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A2agoC6sLRhWE9keKUCQElnqL0CvE3vVL5dLxu90aPE=; b=QvaSM22DIAIzMENjOK7EBeE1edcrIpimKu0nYtY6HqlRzZyiiA/Msls54KF58BP+zC91g7 81D+gAWkjp1ciQnuAAn3S+QeXyec3A8xKxG4fgBVOAx49xmvmUc0I2t+mhiy3OJSv5iNog 0KzR2WX7Cz+0CYFEj3pOc6wI5mMLQzA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-L56dv5foMLisbYovF0kLHA-1; Mon, 28 Jun 2021 06:44:50 -0400 X-MC-Unique: L56dv5foMLisbYovF0kLHA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBB6019253C4; Mon, 28 Jun 2021 10:44:48 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.194.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46C435C1CF; Mon, 28 Jun 2021 10:44:43 +0000 (UTC) From: Vitaly Kuznetsov To: kvm@vger.kernel.org, Paolo Bonzini Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Maxim Levitsky , Cathy Avery , Emanuele Giuseppe Esposito , Tom Lendacky , Michael Roth , linux-kernel@vger.kernel.org Subject: [PATCH 3/6] KVM: nSVM: Introduce svm_copy_nonvmloadsave_state() Date: Mon, 28 Jun 2021 12:44:22 +0200 Message-Id: <20210628104425.391276-4-vkuznets@redhat.com> In-Reply-To: <20210628104425.391276-1-vkuznets@redhat.com> References: <20210628104425.391276-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Separate the code setting non-VMLOAD-VMSAVE state from svm_set_nested_state() into its own function. This is going to be re-used from svm_enter_smm()/svm_leave_smm(). Signed-off-by: Vitaly Kuznetsov --- arch/x86/kvm/svm/nested.c | 36 +++++++++++++++++++++--------------- arch/x86/kvm/svm/svm.h | 2 ++ 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index 1c6b0698b52e..a1dec2c40181 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -697,6 +697,26 @@ int nested_svm_vmrun(struct kvm_vcpu *vcpu) return ret; } +void svm_copy_nonvmloadsave_state(struct vmcb_save_area *from_save, + struct vmcb_save_area *to_save) +{ + to_save->es = from_save->es; + to_save->cs = from_save->cs; + to_save->ss = from_save->ss; + to_save->ds = from_save->ds; + to_save->gdtr = from_save->gdtr; + to_save->idtr = from_save->idtr; + to_save->rflags = from_save->rflags | X86_EFLAGS_FIXED; + to_save->efer = from_save->efer; + to_save->cr0 = from_save->cr0; + to_save->cr3 = from_save->cr3; + to_save->cr4 = from_save->cr4; + to_save->rax = from_save->rax; + to_save->rsp = from_save->rsp; + to_save->rip = from_save->rip; + to_save->cpl = 0; +} + void nested_svm_vmloadsave(struct vmcb *from_vmcb, struct vmcb *to_vmcb) { to_vmcb->save.fs = from_vmcb->save.fs; @@ -1360,21 +1380,7 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu, svm->nested.vmcb12_gpa = kvm_state->hdr.svm.vmcb_pa; - svm->vmcb01.ptr->save.es = save->es; - svm->vmcb01.ptr->save.cs = save->cs; - svm->vmcb01.ptr->save.ss = save->ss; - svm->vmcb01.ptr->save.ds = save->ds; - svm->vmcb01.ptr->save.gdtr = save->gdtr; - svm->vmcb01.ptr->save.idtr = save->idtr; - svm->vmcb01.ptr->save.rflags = save->rflags | X86_EFLAGS_FIXED; - svm->vmcb01.ptr->save.efer = save->efer; - svm->vmcb01.ptr->save.cr0 = save->cr0; - svm->vmcb01.ptr->save.cr3 = save->cr3; - svm->vmcb01.ptr->save.cr4 = save->cr4; - svm->vmcb01.ptr->save.rax = save->rax; - svm->vmcb01.ptr->save.rsp = save->rsp; - svm->vmcb01.ptr->save.rip = save->rip; - svm->vmcb01.ptr->save.cpl = 0; + svm_copy_nonvmloadsave_state(save, &svm->vmcb01.ptr->save); nested_load_control_from_vmcb12(svm, ctl); diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index f89b623bb591..ff2dac2b23b6 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -463,6 +463,8 @@ void svm_leave_nested(struct vcpu_svm *svm); void svm_free_nested(struct vcpu_svm *svm); int svm_allocate_nested(struct vcpu_svm *svm); int nested_svm_vmrun(struct kvm_vcpu *vcpu); +void svm_copy_nonvmloadsave_state(struct vmcb_save_area *from_save, + struct vmcb_save_area *to_save); void nested_svm_vmloadsave(struct vmcb *from_vmcb, struct vmcb *to_vmcb); int nested_svm_vmexit(struct vcpu_svm *svm); -- 2.31.1