Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: tdas=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 00D7BC433F1
Subject: Re: [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in
 alpha_pll_fabia_prepare
To:     Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20210609022852.4151-1-jonathan@marek.ca>
From:   Taniya Das <tdas@codeaurora.org>
Message-ID: <bc6bd251-bd17-1f21-d205-ef343232993b@codeaurora.org>
Date:   Mon, 28 Jun 2021 16:25:51 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210609022852.4151-1-jonathan@marek.ca>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Reviewed-by: Taniya Das <tdas@codeaurora.org>

On 6/9/2021 7:58 AM, Jonathan Marek wrote:
> Caught this when looking at alpha-pll code. Untested but it is clear that
> this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.
> 
> Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
>   drivers/clk/qcom/clk-alpha-pll.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index 94b53c7db2f7f..eaedcceb766f9 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -1255,7 +1255,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw)
>   		return ret;
>   
>   	/* Setup PLL for calibration frequency */
> -	regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
> +	regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l);
>   
>   	/* Bringup the PLL at calibration frequency */
>   	ret = clk_alpha_pll_enable(hw);
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--