Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3431904pxv; Mon, 28 Jun 2021 04:32:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyp6+bowOx+QK1dun+yrmZdfa+5dFwbATrEiOKRAF2zv+CHduN7VXmO8tI7+kFZ4XDA4/ai X-Received: by 2002:a92:1310:: with SMTP id 16mr19104697ilt.60.1624879960867; Mon, 28 Jun 2021 04:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624879960; cv=none; d=google.com; s=arc-20160816; b=ccL58E+wWeoXLV1N4ty59a7qcowbUK8HLQjm35TI2W/4Cm7cRxOtd4oWhJpPvKNqvz YS8Zmhl6kHK9feMOqaElfkhpYQSFW9O7uvgryshAHL/taLxox020utpF+JyYWsY8bIYk v0jH6hnypWM5tr4gShPspSTTVZY1/nz3P9GMoqVRoR/J9Uoj59Oq/QFjOCkv8kYI9vfh JpY9s6KaxAyRhW8P5BWs8DzTFjBLKlNECA37Zg9/d1Mcf6LMg5kRqxH8p79smM2Jixcu Vc57TVsqXOxUgnyc0Id4dfmHBWb1LoqEGXQ/JGAjjjT+5IfjO2N0n65TSDuPq8S8x1YP TEFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Zjneu4o7Ur583DonvIg5dxyAun0EL71ICH2wIraPRIw=; b=GsH4fIxSH4H7JbtA1Nl28OKJOXdhLUjq5sD/kLM4y/okRJsIQKJ9YMtl60dWROK+na XyzND3qSJjECQZpjJ/jw1yMwXnFQbWVHyOQ85iLsrpB3PQoJ9lnypiyKKuZ1lOWQ1iyE BW5TnXUqduseRZBtP2BI5JgLBb5u3inqJ9WvnNafUAmPak2Eu8vZpAgrWAndVS9NhM1R cHaZEWJtxwji2qUp2xL0dE352Y7ZiARX5ySS/IORYewW7AEIiOGIpdkccHyYy8xx23vD KMeOvCJ3HWoD9dugmRYByHRxQ0ix1DTshe00jJR4q2wRaovNm2MWpddE+ASmOqpMhIoz cGoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y196si13880294iof.35.2021.06.28.04.32.28; Mon, 28 Jun 2021 04:32:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232686AbhF1KlE (ORCPT + 99 others); Mon, 28 Jun 2021 06:41:04 -0400 Received: from foss.arm.com ([217.140.110.172]:56196 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231935AbhF1KlE (ORCPT ); Mon, 28 Jun 2021 06:41:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DE28D6E; Mon, 28 Jun 2021 03:38:38 -0700 (PDT) Received: from [10.57.8.231] (unknown [10.57.8.231]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23C2B3F694; Mon, 28 Jun 2021 03:38:36 -0700 (PDT) Subject: Re: [PATCH v7 2/2] perf cs-etm: Split --dump-raw-trace by AUX records To: Leo Yan Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, John Garry , Will Deacon , Mike Leach , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210624164303.28632-1-james.clark@arm.com> <20210624164303.28632-3-james.clark@arm.com> <20210628012744.GA158794@leoy-ThinkPad-X240s> From: James Clark Message-ID: Date: Mon, 28 Jun 2021 11:38:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210628012744.GA158794@leoy-ThinkPad-X240s> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/06/2021 02:27, Leo Yan wrote: > Hi James, > > On Thu, Jun 24, 2021 at 05:43:03PM +0100, James Clark wrote: >> Currently --dump-raw-trace skips queueing and splitting buffers because >> of an early exit condition in cs_etm__process_auxtrace_info(). Once >> that is removed we can print the split data by using the queues >> and searching for split buffers with the same reference as the >> one that is currently being processed. >> >> This keeps the same behaviour of dumping in file order when an AUXTRACE >> event appears, rather than moving trace dump to where AUX records are in >> the file. >> >> There will be a newline and size printout for each fragment. For example >> this buffer is comprised of two AUX records, but was printed as one: >> >> 0 0 0x8098 [0x30]: PERF_RECORD_AUXTRACE size: 0xa0 offset: 0 ref: 0x491a4dfc52fc0e6e idx: 0 t >> >> . ... CoreSight ETM Trace data: size 160 bytes >> Idx:0; ID:10; I_ASYNC : Alignment Synchronisation. >> Idx:12; ID:10; I_TRACE_INFO : Trace Info.; INFO=0x0 { CC.0 } >> Idx:17; ID:10; I_ADDR_L_64IS0 : Address, Long, 64 bit, IS0.; Addr=0x0000000000000000; >> Idx:80; ID:10; I_ASYNC : Alignment Synchronisation. >> Idx:92; ID:10; I_TRACE_INFO : Trace Info.; INFO=0x0 { CC.0 } >> Idx:97; ID:10; I_ADDR_L_64IS0 : Address, Long, 64 bit, IS0.; Addr=0xFFFFDE2AD3FD76D4; >> >> But is now printed as two fragments: >> >> 0 0 0x8098 [0x30]: PERF_RECORD_AUXTRACE size: 0xa0 offset: 0 ref: 0x491a4dfc52fc0e6e idx: 0 t >> >> . ... CoreSight ETM Trace data: size 80 bytes >> Idx:0; ID:10; I_ASYNC : Alignment Synchronisation. >> Idx:12; ID:10; I_TRACE_INFO : Trace Info.; INFO=0x0 { CC.0 } >> Idx:17; ID:10; I_ADDR_L_64IS0 : Address, Long, 64 bit, IS0.; Addr=0x0000000000000000; >> >> . ... CoreSight ETM Trace data: size 80 bytes >> Idx:80; ID:10; I_ASYNC : Alignment Synchronisation. >> Idx:92; ID:10; I_TRACE_INFO : Trace Info.; INFO=0x0 { CC.0 } >> Idx:97; ID:10; I_ADDR_L_64IS0 : Address, Long, 64 bit, IS0.; Addr=0xFFFFDE2AD3FD76D4; >> >> Decoding errors that appeared in problematic files are now not present, >> for example: >> >> Idx:808; ID:1c; I_BAD_SEQUENCE : Invalid Sequence in packet.[I_ASYNC] >> ... >> PKTP_ETMV4I_0016 : 0x0014 (OCSD_ERR_INVALID_PCKT_HDR) [Invalid packet header]; TrcIdx=822 >> >> Signed-off-by: James Clark > > I tested this patch and the result looks good for me. > > I found a side effect introduced by this change is the perf raw dump > also synthesizes events PERF_RECORD_ATTR. This is because function > cs_etm__synth_events() will execute after applying this patch and it > synthesizes PERF_RECORD_ATTR events. I don't see any harm for this, > so: > > Tested-by: Leo Yan > Thanks for the testing! > Please see an extra comment in below. > >> --- >> tools/perf/util/cs-etm.c | 20 ++++++++++++++++++-- >> 1 file changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c >> index 88e8122f73c9..ad777c2a342f 100644 >> --- a/tools/perf/util/cs-etm.c >> +++ b/tools/perf/util/cs-etm.c >> @@ -2430,6 +2430,22 @@ static int cs_etm__process_event(struct perf_session *session, >> return 0; >> } >> >> +static void dump_queued_data(struct cs_etm_auxtrace *etm, >> + struct perf_record_auxtrace *event) >> +{ >> + struct auxtrace_buffer *buf; >> + unsigned int i; >> + /* >> + * Find all buffers with same reference in the queues and dump them. >> + * This is because the queues can contain multiple entries of the same >> + * buffer that were split on aux records. >> + */ >> + for (i = 0; i < etm->queues.nr_queues; ++i) >> + list_for_each_entry(buf, &etm->queues.queue_array[i].head, list) >> + if (buf->reference == event->reference) >> + cs_etm__dump_event(etm, buf); >> +} >> + >> static int cs_etm__process_auxtrace_event(struct perf_session *session, >> union perf_event *event, >> struct perf_tool *tool __maybe_unused) >> @@ -2462,7 +2478,8 @@ static int cs_etm__process_auxtrace_event(struct perf_session *session, >> cs_etm__dump_event(etm, buffer); >> auxtrace_buffer__put_data(buffer); >> } >> - } >> + } else if (dump_trace) >> + dump_queued_data(etm, &event->auxtrace); > > IIUC, in the function cs_etm__process_auxtrace_event(), since > "etm->data_queued" is always true, below flow will never run: > > if (!etm->data_queued) { > ...... > > if (dump_trace) > if (auxtrace_buffer__get_data(buffer, fd)) { > cs_etm__dump_event(etm, buffer); > auxtrace_buffer__put_data(buffer); > } > } > > If so, it's better to use a new patch to polish the code. > Hi Leo, I think this is not true in piped mode because there is no auxtrace index. In that mode, events are processed only in file order and cs_etm__process_auxtrace_event() is called for each buffer. You can reproduce this with something like this: ./perf record -o - ls > stdio.data cat stdio.data | ./perf report -i - There are some other Coresight features that don't work as expected in this mode, like sorting timestamps between CPUs. The aux split patchset won't work either because random access isn't possible. And the TRBE patch that I'm working on now won't work, because it also requires the random access to lookup the flags on the AUX record to configure the decoder for unformatted trace. Thanks James > Thanks, > Leo > >> >> return 0; >> } >> @@ -3038,7 +3055,6 @@ int cs_etm__process_auxtrace_info(union perf_event *event, >> >> if (dump_trace) { >> cs_etm__print_auxtrace_info(auxtrace_info->priv, num_cpu); >> - return 0; >> } >> >> err = cs_etm__synth_events(etm, session); >> -- >> 2.28.0 >>