Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3473338pxv; Mon, 28 Jun 2021 05:27:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPdgMJmj4a5/tEBMYB7EY0oGWV0aiOHS7RGlLLTXohnTkc/aaJzqkE0ybvKJQjJ6xRmc+V X-Received: by 2002:a17:906:79cf:: with SMTP id m15mr23597842ejo.465.1624883242132; Mon, 28 Jun 2021 05:27:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624883242; cv=none; d=google.com; s=arc-20160816; b=Jy4oaeHu4njcr2F62U/RGN3cN5Tv1QvJbj80btxBzXqVmaAg9V54Cqb1YWBZN5FrxE lY6p7GVIAIlNyk75AmNg/J5+Kd2s71Y9Y311d/arYFxk1wnhrlUHCqXT+9Eb58MREC1l Od6SOMJLRYg9hmnSY4F6maiSd0XADMZeJuUVUpVSt9iOllNkQlnWvIQT1gkP5jCVpqvY uGZ8ZC/+cWM0X3mZGLjDBwE5p+7LXyMAvWLEEY35Gx8/V1p5Pl/tnVq3nTzZ6lOm1+ra zuHrPWtn67ZiokmRH6/PI7ytkLXNf/aaxirrsHqdaRiqs3KcdP9+DqTnpkDnHQ1ukRaI /SmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=acP5uzFdW1Ht90PhtySU1kJQyH71L3NOJrM6+TwWOfY=; b=SLFVXKstxLhG/Ywp1TBoT/yRFoyf09EJeRc34COkxyycYhYbAYRnYBF6amkApAXbQe YAyZ3C6KUYA2XbdEhv44IefN5YcBOAmHXmF8PuUTg8fIXGwqX1+DnNUmzgERyHGN19Rh 3g2frC2OuhWXAvWmsA4jj0eLsf8yh8cOqVZ/ECo5q32RIzwqPeigqVtCp1uMxK3cVjG9 ZJseyw3JolRdCTbPCZRbdm8PoHhaVYUtIUaohzionnQpmI/cj1OTHrm8pgoEmJUye0ne tJTD734MbKnR+zu+izxvhEpE1hKpPNY/BMOKpmQ992SPPpeQ6GUiWVvrju2EOeIEeyDN D+pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UJV4M4KS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si11633692ejc.554.2021.06.28.05.26.58; Mon, 28 Jun 2021 05:27:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UJV4M4KS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232932AbhF1M01 (ORCPT + 99 others); Mon, 28 Jun 2021 08:26:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27382 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbhF1M00 (ORCPT ); Mon, 28 Jun 2021 08:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624883040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=acP5uzFdW1Ht90PhtySU1kJQyH71L3NOJrM6+TwWOfY=; b=UJV4M4KS0jn+qn9DMljcfg8TZgpCFsOj8GLz0v1UpXFePkn9howxt5VAjFNnI5U8qoAzXJ xDZHX/8/RT6Bk5WUYx7qUx8uty5bgGIXCj5UGMTgmqbb/NPWycEfM6RkHy1cv7vt1vYFji 2MsJ8qyFIQsgwPKSWfERZM+090RLugs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-H1Y9L_JqNA-zaE6brQ-dFQ-1; Mon, 28 Jun 2021 08:23:59 -0400 X-MC-Unique: H1Y9L_JqNA-zaE6brQ-dFQ-1 Received: by mail-wm1-f72.google.com with SMTP id j38-20020a05600c1c26b02901dbf7d18ff8so8910130wms.8 for ; Mon, 28 Jun 2021 05:23:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=acP5uzFdW1Ht90PhtySU1kJQyH71L3NOJrM6+TwWOfY=; b=pPZL/xpgWStwfPgx81q5bVKuqdmlLIXgr/ngB1do5jptPLdOtvvwqVA8pl7fAQR/Xt LSyro1B0Lz07EDTMNUK/A/u3AbONsYgGERuUcsbFb4ut0FLJlyclkc5Uk8sHiUm18YqS IFZc97Gb/pyDceRgIhxs9rRy39Yo82P5Ysr/t3HkrqrR5GrhT89VtMATWBIcsi5uE7Lr 8EZIJnA4C4+KETBmTgR427ErDfbaW3inCBPZi/ARg+L46njkzJE1FtWzVFwmrUF/Q8ve ezVU4qiEeUJt0T3eJ3K93LfEKEYQASOHWU5RCsDTbkReSZNosVphrqngzDn3ChtLXfyR UATQ== X-Gm-Message-State: AOAM533r3PRzQoamjwh8RM1kfkCR76uiNky8xMKVFXEP+m2fxKBX2Di2 65TijLZJaWZYaWnWnpq7+iT8P4zGkOZ8VrUNAnmiMTpLW8W8gYph/BBnx2pypSE/cpi9ccdBZXK s5KEoXwM/snzX/z72b9PNm//fGMITpuNz2lSNZbUH X-Received: by 2002:a05:6000:112:: with SMTP id o18mr26070644wrx.289.1624883038193; Mon, 28 Jun 2021 05:23:58 -0700 (PDT) X-Received: by 2002:a05:6000:112:: with SMTP id o18mr26070626wrx.289.1624883038028; Mon, 28 Jun 2021 05:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20210628111450.194262-1-jingxiangfeng@huawei.com> In-Reply-To: <20210628111450.194262-1-jingxiangfeng@huawei.com> From: Andreas Gruenbacher Date: Mon, 28 Jun 2021 14:23:47 +0200 Message-ID: Subject: Re: [PATCH] gfs2: Fix error handling in init_statfs() To: Jing Xiangfeng Cc: Bob Peterson , Abhijith Das , cluster-devel , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jing, On Mon, Jun 28, 2021 at 1:22 PM Jing Xiangfeng wrote: > In an error path of init_statfs(), it calls iput to put pn which has been > put. Jump to correct label to fix it. thanks for your patch. This looks okay, but I'd rather set pn to NULL after the iput instead. Since iput(NULL) is a no-op, we'll end up with the same result. Andreas