Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3558543pxv; Mon, 28 Jun 2021 07:22:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7efNVSP7G1q04K391dzX2x82jwbe18fmx6/PKYuhsqL82BjUv1GukDmzh9eXe0v3Q/lgs X-Received: by 2002:a05:6e02:1145:: with SMTP id o5mr8452551ill.101.1624890151092; Mon, 28 Jun 2021 07:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624890151; cv=none; d=google.com; s=arc-20160816; b=nCw8nxUIl9VFlJBJcmRkAzkPD+gRh+feXEvLhFnevPzKwFUpCP4GAEPIQ7JDK3c8xU //qVJPDUofqtMxgO/ZVgGc40dyvkE/jRvubtbxVHN7hFaZhSlXugg7LsNd8r74lQFQQT s8uXq5kvj1LAYmwny4d9tv+tts1IDloLmMbsNCl0mY/R5w97S2CBQQGYvi4SfLDHhfpX HrUXW6Qe4t4U/qW6qFVMtxxQRTIHrJtXVh4xo2ya5hDs9nTieewDKpIE8IJTNP1bdTE5 zLxEtt15fscd15IHuLeDm/Uxi6gz0BG9Bqk5j0NxL8UzhCkGftosy7D1QNjs6OXbrads 8wvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aNyb/UKy6G79UhshqC2tw+/pWI23e5WSTaT1u5+y4HY=; b=LobglaZOn0E6u3bG/RfrSZJZ4ur0ieskcvGea1bcG+rf4BIjlvk83HHeQnqRIqqPe7 +OEITn0JyyiQvnQHTa9STw6jtT+a+o+Up410D4qvkBZBbtpfqCBeb+SZwjHqtGjxd0Ic Nc6T33XvxMccCK/ZxBDvDTuv44C6i+cMfvoz4FCJI0uSOFUASZHrfxxD4assgq8+tjmW DGwtBCcfm5laAtsxGUD7FNY2+xW6TxIt825ZQAXSR9qnZsyrYpAxf53aXJcKOh0JU6Z4 i+0wTu8xIXTGyJVr8q57TAM6M7+9zLMmVw6WgwWNK0XsTNjRx4eEuxFhD/ZurPjD2s9I 9dnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nrEzjtFm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si21469958ilh.114.2021.06.28.07.22.15; Mon, 28 Jun 2021 07:22:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nrEzjtFm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233591AbhF1OXU (ORCPT + 99 others); Mon, 28 Jun 2021 10:23:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:54752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232840AbhF1OVV (ORCPT ); Mon, 28 Jun 2021 10:21:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BA07761C7E; Mon, 28 Jun 2021 14:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624889935; bh=7FejGutx7qigxlPOnRTPF0t+VREiWTptDfU4R0WFxNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nrEzjtFmHMbIZBxwLw4h4s/jsbOEHDzUg9K8+zYRyRPnGIgCTTa1MTsgnNT1i7Akc LEUwEUWVDQs5TiroW8esp2u8KB5rJ+xcoYvDZivd49qNKx99Rca7F5XGzXHCXIF+0W sGuUHcalTar2UsDgugMIRpLRbjzQNKIHCNAc7/FmIRfbG0qBELiN8Jm42FvoOJUntc Lx34WVB3YRF4ZKFGYco4kqa6g6RrSU2YupymMEmUYttZ0E7Agy07L7s+uAH5V9DBzN 2BUgCUnMthjhdKHjIikns1K5VCVcOI39TIpGTvDoizyO4jwcZJnuEh95mBjR26bg1k /86UfIWIF4qBA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiapeng Chong , Abaci Robot , Dave Jiang , Vinod Koul , Sasha Levin Subject: [PATCH 5.12 029/110] dmaengine: idxd: Fix missing error code in idxd_cdev_open() Date: Mon, 28 Jun 2021 10:17:07 -0400 Message-Id: <20210628141828.31757-30-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210628141828.31757-1-sashal@kernel.org> References: <20210628141828.31757-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.12.14-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.12.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.12.14-rc1 X-KernelTest-Deadline: 2021-06-30T14:18+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit 99b18e88a1cf737ae924123d63b46d9a3d17b1af ] The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/dma/idxd/cdev.c:113 idxd_cdev_open() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Acked-by: Dave Jiang Link: https://lore.kernel.org/r/1622628446-87909-1-git-send-email-jiapeng.chong@linux.alibaba.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/idxd/cdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c index 1d8a3876b745..5ba8e8bc609f 100644 --- a/drivers/dma/idxd/cdev.c +++ b/drivers/dma/idxd/cdev.c @@ -110,6 +110,7 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp) pasid = iommu_sva_get_pasid(sva); if (pasid == IOMMU_PASID_INVALID) { iommu_sva_unbind_device(sva); + rc = -EINVAL; goto failed; } -- 2.30.2