Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Chrisanthus, Anitha" <anitha.chrisanthus@intel.com>
To:     Sasha Levin <sashal@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
CC:     Zhen Lei <thunder.leizhen@huawei.com>,
        Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH 5.12 019/110] drm/kmb: Fix error return code in
 kmb_hw_init()
Thread-Topic: [PATCH 5.12 019/110] drm/kmb: Fix error return code in
 kmb_hw_init()
Thread-Index: AQHXbCiO5NNGuFG7IEKifxAIWui3IKspnNXQ
Date:   Mon, 28 Jun 2021 16:29:37 +0000
Message-ID: <BY5PR11MB418269C8584FC8AAD088CA9C8C039@BY5PR11MB4182.namprd11.prod.outlook.com>
References: <20210628141828.31757-1-sashal@kernel.org>
 <20210628141828.31757-20-sashal@kernel.org>
In-Reply-To: <20210628141828.31757-20-sashal@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u7tJg3pT/O2KzYCKidUs8m6UlFPWBqWiZAFxiR/A+2kMVX1Mhwl32PWEx9GS?=
 =?us-ascii?Q?GkUPklIDZSnbo1izXn1lUlW6NuoaWTyRfjAuiBfGjg/AWeyjAD7cbZFQ4H2y?=
 =?us-ascii?Q?APgbtkf8POEsV1ZPL8cmKFIc2IoITCsTdeyVjjg6ZLKZRFumCakc6Oi272Iq?=
 =?us-ascii?Q?v/7MkO6iTzxgIoyKTo4ALRxmyh8exeyD7fonie5s+5whymo75MfVTpEMRtBo?=
 =?us-ascii?Q?YVQ1FATbKYWGaA+NHTCHmTc6mgcDBYRxazEyjjJ102QUPEE30w+q7LZORAN3?=
 =?us-ascii?Q?GAzzYrSfrmd86yJt5UwbOju/Q+JYziFGf/dt0uOGnJ09XSE3IUkLotxTvSBg?=
 =?us-ascii?Q?Fn2o9kz59c6L1dvZrIvn1/ciBCgDHvc/MnqqrrtEhkp7XhbdImvsE70vVjtk?=
 =?us-ascii?Q?IPWk6Sk6Cx3dxhMJ8p4gmXY+o67DHsQz6JDJeNHA6dYy5hwxQW+NW3tX8o6j?=
 =?us-ascii?Q?aI/78mPE+fgbsRyuGf+E/djs7uE/KiGl238JOICPOwRq8eZgQ880HD8ylzub?=
 =?us-ascii?Q?vFsV2bGnV1L/NqMpYtE7uH48k7EOLsT9O6/45Vh7YEpRjp4TTfccFzaXzZnt?=
 =?us-ascii?Q?N3TIHDE++k3rlQWgnarYN5rlIJVGjzukhIecrhzOwUFj349o9uhJP1zXHs3J?=
 =?us-ascii?Q?ylluU5mp2gL2V3n5r90fw8vinFuyshsWWAORai4JX4DxRp4+crB9QUCF6UUg?=
 =?us-ascii?Q?eAIiaJbkwZQsrld9tCW+MIk6TlyQ2yM77VtXVy2/XA7WhHar9J2mbl72oAnE?=
 =?us-ascii?Q?8AGyq/Kf9SziUFohGtLznMjHHITe8koDVQTV6jWfBH13N3+a0ogvSVxDgcQJ?=
 =?us-ascii?Q?Co6lhJ+ugP22BKcBDw2tNvt1NUk9L5eDfC9HrbY01F8XHTcEt7OWJfzgNu5m?=
 =?us-ascii?Q?U15YFDImdepOkYb/0PxELMvaBgNYaveb+SFcjhACTSOQYz62se/R4VylAL5b?=
 =?us-ascii?Q?DJ14GPf+msvnwJ0boj0vnM7lsfmuuOgltXgpPxkctghQH+Wys3DCiWDHENqa?=
 =?us-ascii?Q?tnoe6Jb0w5v4LyPrzZOcIrZhJvaYTzLqF/vrb17WLfonsbSkkJ+pQwZvDz2g?=
 =?us-ascii?Q?dH18fjmoaCOS2dDAFEMpljneGhlkgmI3j6GLuwCCZibQlGtt/J2ncksrClrw?=
 =?us-ascii?Q?biN6oC/1JxzOQtF4q6qEjkbn7F4qJc4CtNh4J7sFWWmUlgoA6/dtqoRUtV6C?=
 =?us-ascii?Q?nwspPpPNkKC2g38unYn6ug5X6yslzasOBviGR27WaX9GSeW7AhcCFBKVI7R9?=
 =?us-ascii?Q?L8LLC4c9eP+hLi7MuMdAkMTWUnr7sIjRI8JrA/i9OTnydRKacQj95UVNPkuo?=
 =?us-ascii?Q?OGk=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4182.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c40edb3a-9008-43c8-a502-08d93a51ebe0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2021 16:29:37.2816
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 706XFFAuqWNVpXKBfEMvopT6Mm2wzhNCvpvQ2QKSKtXcjGHGMSABTPQnOfkPrJo2MeuvI/4xeMQb/sEdQQeNAUpwbK+uFxu9MVtB/2fuOpU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5005
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch is already pushed to drm-misc-fixes. Please check for existing p=
atches in the dri-devel mail list before sending patches.

Thanks,
Anitha

> -----Original Message-----
> From: Sasha Levin <sashal@kernel.org>
> Sent: Monday, June 28, 2021 7:17 AM
> To: linux-kernel@vger.kernel.org; stable@vger.kernel.org
> Cc: Zhen Lei <thunder.leizhen@huawei.com>; Hulk Robot
> <hulkci@huawei.com>; Chrisanthus, Anitha <anitha.chrisanthus@intel.com>;
> Sasha Levin <sashal@kernel.org>
> Subject: [PATCH 5.12 019/110] drm/kmb: Fix error return code in
> kmb_hw_init()
>=20
> From: Zhen Lei <thunder.leizhen@huawei.com>
>=20
> [ Upstream commit 6fd8f323b3e4e5290d02174559308669507c00dd ]
>=20
> When the call to platform_get_irq() to obtain the IRQ of the lcd fails, t=
he
> returned error code should be propagated. However, we currently do not
> explicitly assign this error code to 'ret'. As a result, 0 was incorrectl=
y
> returned.
>=20
> Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20210513134639.6541-
> 1-thunder.leizhen@huawei.com
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/gpu/drm/kmb/kmb_drv.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index f64e06e1067d..96ea1a2c11dd 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -137,6 +137,7 @@ static int kmb_hw_init(struct drm_device *drm,
> unsigned long flags)
>  	/* Allocate LCD interrupt resources */
>  	irq_lcd =3D platform_get_irq(pdev, 0);
>  	if (irq_lcd < 0) {
> +		ret =3D irq_lcd;
>  		drm_err(&kmb->drm, "irq_lcd not found");
>  		goto setup_fail;
>  	}
> --
> 2.30.2