Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3702248pxv; Mon, 28 Jun 2021 10:39:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUhZXW/0NC32/TIjxfOz0MmLm4XW6VjZ370Xv0mehr9lgU+hPlRZTHuq+/8Hkm/uEmL4a+ X-Received: by 2002:a6b:7948:: with SMTP id j8mr487142iop.32.1624901976462; Mon, 28 Jun 2021 10:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624901976; cv=none; d=google.com; s=arc-20160816; b=q5DuAN1lV/sqguEzHuRu2HO/LNV7n81j7svG0xch+y3K3x95/gRk64796C8JVndlLb +GCeAy//BpkmWCaS25408FEq9SR5PtkY9iwnekEFFQHGwj8NKgZ/pNWb0gUvvTeag2QW 4Ya7x8Y+lJCVFUZ9cngT9AIJMS6FIfi3NsdHGSpqF86ESFhJVtSVWaOcmrZ4kwjYleud EQ3JiVf9+fButwpBB8v+kNCmjBl14LhSxp+/SubXEsKDii7+yeK6sUkECTmHXS9JSPz6 h1q7j1cBTuFlHAhrdCDS2Ua5Z+c8/kvSwWCM84IONXc+KQD+UV4YzJx2LcRnsPlFmLp3 ecBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ij+EHG4HaHxXg3uARO1DV7tQvdRYtNZMjGqevU3J1i8=; b=YejqjRr/OhBNk+lmW7xMaftdkjaw6HowZkrD2Ce3Gd/I+vky/E+eO1FS6RSxBTwpAi x7WJRqTVeqxriJvjvItw0iq1s4kFHUA81ltivFm3CtmFKAyqVIONMi9DgMYbfjK43ERa Lr9Ia5QJcl0rbRUsSHUiYnsVWVasedHiwhIiotntFWTwwXBV74ZDmUAIwQRmSvDVFcLx GnLxW+bpMCurWYK1ffJCcYQyXcnsxET/iIxQxBoKd5u/8pbyHnz10HfH730pyrtLp/Yc 1UDqbK+gyj2ROfsRT/WrRsPzGZMtHuHSwvaJGB7TJeg9pwTbHNnr+CjcyQDWtpIy2C9d 8F1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qO1lP1QA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si21776480jad.121.2021.06.28.10.39.21; Mon, 28 Jun 2021 10:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qO1lP1QA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233568AbhF1OYk (ORCPT + 99 others); Mon, 28 Jun 2021 10:24:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:54752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233171AbhF1OVd (ORCPT ); Mon, 28 Jun 2021 10:21:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E40561C85; Mon, 28 Jun 2021 14:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624889947; bh=BaNvhATeEufCxlq19nIJTaVOVFK2DRAYVIjsRxIn9Hw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qO1lP1QA+Lbi5mj3THHQX8OxPtVkpGWzLS7HaJKR5u/MwZh2nPYwbkobxDMaLoZBy /le9EU8Fo23RA3UUUkagTNfF8w9+BZzI9DIeZyPHkJJYZlxi+EvEHn+WDxtk0cyG6x ZFta9NMRxr0IR6pMHtnp55vflXZ0FaMParWn0m15pRFUC4lwSo3+31yxR+BD0Fx46V VnMrTmgMOfG4I50wce/bp4IxBNgpqZw2hqA4majPdSOye2tMQwJ+bhUK/0VuWv5zu0 7yqX75w/e0PDRQw+p2qW+JTAf6uZgG2pPAHqUkFipH4nty26BlNM/K0L33rfqqJ4QG Pw5eADpu4zP8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavel Skripkin , syzbot+f303e045423e617d2cad@syzkaller.appspotmail.com, "David S . Miller" , Sasha Levin Subject: [PATCH 5.12 044/110] net: caif: fix memory leak in ldisc_open Date: Mon, 28 Jun 2021 10:17:22 -0400 Message-Id: <20210628141828.31757-45-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210628141828.31757-1-sashal@kernel.org> References: <20210628141828.31757-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.12.14-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.12.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.12.14-rc1 X-KernelTest-Deadline: 2021-06-30T14:18+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin [ Upstream commit 58af3d3d54e87bfc1f936e16c04ade3369d34011 ] Syzbot reported memory leak in tty_init_dev(). The problem was in unputted tty in ldisc_open() static int ldisc_open(struct tty_struct *tty) { ... ser->tty = tty_kref_get(tty); ... result = register_netdevice(dev); if (result) { rtnl_unlock(); free_netdev(dev); return -ENODEV; } ... } Ser pointer is netdev private_data, so after free_netdev() this pointer goes away with unputted tty reference. So, fix it by adding tty_kref_put() before freeing netdev. Reported-and-tested-by: syzbot+f303e045423e617d2cad@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/caif/caif_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c index 9f30748da4ab..8c38f224becb 100644 --- a/drivers/net/caif/caif_serial.c +++ b/drivers/net/caif/caif_serial.c @@ -350,6 +350,7 @@ static int ldisc_open(struct tty_struct *tty) rtnl_lock(); result = register_netdevice(dev); if (result) { + tty_kref_put(tty); rtnl_unlock(); free_netdev(dev); return -ENODEV; -- 2.30.2