Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3730802pxv; Mon, 28 Jun 2021 11:21:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcGMQ3gD0pBSpjPhWgUyEz0mXtelaueqW3qO1fPhGQq/EbA9R+c9DWZAq8bo1PIhf6WHxH X-Received: by 2002:a05:6402:42d2:: with SMTP id i18mr34424405edc.168.1624904519235; Mon, 28 Jun 2021 11:21:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624904519; cv=none; d=google.com; s=arc-20160816; b=j5yOnybajNOh3TcgFc/xucRCdPZc6p+BbbSLkXeVQIJPba6t30P2HZ19TeScJOPV+M gDI5um+IJCAxSqF7zRtgMXxAGGB9D9tbPad7uRig7mQXaYlnKbY8YzKUVzYzUpj8vzmt ggQvaMqkfihST4JP+IBx9L3zQ7Ryx/Zg+ZxOf8AcjHhCJLfLrfvqnv043dwwTo0kwjjR 6qYJ1etwCY3+l+I0NfF+UrVFS/mBqUQuEq73u9aYV151jajdT3AAspcZrHXgaTd67dKz PpRta6No5SQ+3ziCX78o5bdEkbB2CC/kQE9y/9XjaB8Y3bVyqIjLx7ihjahI/edT2IeA RSsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xgzbLjx8D+mZp6A+XJzVOaoKdR3NOn0zwQhoL+n43h8=; b=qsZ1aFcc0VWnjZ93qxH7F2BKrt++JkuZrjNrq/DLVgae+pOMBiO3aRyst1PkUdnSeY ltept07TUkq/7+RZ2HNaXnUrCL9Vu/XajDZ9VJUi64tiCqS50E3o6GCjxJsXr+BMGuxa QjO49sqxTXZGrlQzczNZTHxli/Rg5UY6Rynvg1UHBcaEAp0m8P5FUSfXSDfQoExlseMe 4OXrPyjHV5RFk13s3y5+uEM5bJOMmFaeIBRgc/GbuODwnmNXT2L308oOGUQ81q+pVhaw qOkhEhKh3UmnmkEf9se+m4bd9s51+4MawXSQ8akGuPPT2ESRyWiypxP1n8TUHJBjFpi4 es6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nVdmz36I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si17789169ejc.164.2021.06.28.11.21.35; Mon, 28 Jun 2021 11:21:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nVdmz36I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236532AbhF1Oth (ORCPT + 99 others); Mon, 28 Jun 2021 10:49:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:43968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234175AbhF1OhK (ORCPT ); Mon, 28 Jun 2021 10:37:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E31C61CAE; Mon, 28 Jun 2021 14:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624890646; bh=oBga/J/u8cNhQPE8R0NqSQWs3dwaNBfYqPb2ZELcjJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nVdmz36IuKxHIFXRkCj68LJSIRJ0d6XwEtaLa7AdPsLxTLpDzzb75cjNeSbLlpmes dMnqgHx2MmwSgDfSqD+ANWB7bDknKXjccgnKnshJyFE9lN3L6pYscPxESgkLV73icO nJRDQ9ji06+sayxVKWOcGv+TN+0c305OxXAq1Nt/McVZ2G2PmdYb6suT//iKB0Rkom xpCKWhyn3fkvN6FMlLLPYoU81nYJSYrOGfr7I/xClU73oNm8Aqn03lvPGEEsrg4bQG Ci0gMQaW9WQOzdBJZ6JFpZuy/+4aqEH/SqEiqvGkhfgon2AA9cuO3F+fxdLIucBMcL RDGo5525Oj5RQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Shi , Michal Hocko , Hugh Dickins , Johannes Weiner , Vladimir Davydov , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman Subject: [PATCH 5.4 45/71] mm: add VM_WARN_ON_ONCE_PAGE() macro Date: Mon, 28 Jun 2021 10:29:38 -0400 Message-Id: <20210628143004.32596-46-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210628143004.32596-1-sashal@kernel.org> References: <20210628143004.32596-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.129-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.129-rc1 X-KernelTest-Deadline: 2021-06-30T14:29+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Shi [ Upstream commit a4055888629bc0467d12d912cd7c90acdf3d9b12 part ] Add VM_WARN_ON_ONCE_PAGE() macro. Link: https://lkml.kernel.org/r/1604283436-18880-3-git-send-email-alex.shi@linux.alibaba.com Signed-off-by: Alex Shi Acked-by: Michal Hocko Acked-by: Hugh Dickins Acked-by: Johannes Weiner Cc: Vladimir Davydov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Note on stable backport: original commit was titled mm/memcg: warning on !memcg after readahead page charged which included uses of this macro in mm/memcontrol.c: here omitted. Signed-off-by: Hugh Dickins Signed-off-by: Greg Kroah-Hartman --- include/linux/mmdebug.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h index 2ad72d2c8cc5..5d0767cb424a 100644 --- a/include/linux/mmdebug.h +++ b/include/linux/mmdebug.h @@ -37,6 +37,18 @@ void dump_mm(const struct mm_struct *mm); BUG(); \ } \ } while (0) +#define VM_WARN_ON_ONCE_PAGE(cond, page) ({ \ + static bool __section(".data.once") __warned; \ + int __ret_warn_once = !!(cond); \ + \ + if (unlikely(__ret_warn_once && !__warned)) { \ + dump_page(page, "VM_WARN_ON_ONCE_PAGE(" __stringify(cond)")");\ + __warned = true; \ + WARN_ON(1); \ + } \ + unlikely(__ret_warn_once); \ +}) + #define VM_WARN_ON(cond) (void)WARN_ON(cond) #define VM_WARN_ON_ONCE(cond) (void)WARN_ON_ONCE(cond) #define VM_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) @@ -48,6 +60,7 @@ void dump_mm(const struct mm_struct *mm); #define VM_BUG_ON_MM(cond, mm) VM_BUG_ON(cond) #define VM_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond) #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) +#define VM_WARN_ON_ONCE_PAGE(cond, page) BUILD_BUG_ON_INVALID(cond) #define VM_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) #define VM_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond) #endif -- 2.30.2