Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3731446pxv; Mon, 28 Jun 2021 11:22:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfhAxp0I2sHFg+U6cqS0LF9+gMvbwndv1kreqRhgYAsn+Gdm67yeA4jTFezosNxKn2H5tk X-Received: by 2002:a17:906:dc6:: with SMTP id p6mr25873148eji.283.1624904573603; Mon, 28 Jun 2021 11:22:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624904573; cv=none; d=google.com; s=arc-20160816; b=ScFX9oIiRoxiSYLgwlhFch5Ux5p4iXVxCeaMvolQT+uFhHRZO+raK6IS7b+DFxMofn ShsIpxlOfiCNkp3rB6QmPxrz0tYrY+FKOG2EfExI8ztpyktLXsDDRsGowzhxvQs2FSqb 4vlbtBMFL4DobOs1om2zyIslGKai19GiT1wm+9VS/quzVsu5ROC8stjhfGiW5g9CQ4aA ZiTtFcBFJEPYWJm9CvywNWRgylvTKzjlWjvcEVam0huSlZIRfdIIClW0hC4S7OSNmVL8 nd7rgIwVB6IT2IxBMKHmk91DU6Bbd/0yTs8zsHERkDOQF7sDZJ0eFvzYcrzrYMliWiS1 wNxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f+hnyiDDAghhSvhFkATA3Hyqi1bo/mqwWf+Mx2NWOAE=; b=Td3Ne/hBod8yLOWpCd+xKWftmwvvTcRVt+OAADg6FOrbL361pbkAM4CLgI1xElWFNA zQB+1yD6hxXY+Xek+H2IF2q3+ZOkUWjN/u1jr8TQfEro5wS/63giuPBCURx+U7jchIr/ REWgrbkS1z0q1+d9IJlBPxRAE94Wut4N6+b5xMY93eGaGlOeNnsCBkzna0ZWMU/v4/AR Hi9ZbFv+WTwxNX1zN0EEOduULfUwoAdHWEYycjcMjBOhWg60mn/FqGlwgZGa/aiMa9dL oRcqeV+sKZPNyKPeXAyNyVk9gvkdWc95Mh8WDewawYqOZFTq8kAwp7oY7UKLeSd6u7UR rKzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gh2Dd6Js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ku24si1031833ejc.453.2021.06.28.11.22.26; Mon, 28 Jun 2021 11:22:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gh2Dd6Js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234991AbhF1Onp (ORCPT + 99 others); Mon, 28 Jun 2021 10:43:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:36746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234946AbhF1Oe0 (ORCPT ); Mon, 28 Jun 2021 10:34:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DEC4961C76; Mon, 28 Jun 2021 14:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624890608; bh=2BOiD0v0pNnWYR92AF59bpJkxCadHEBlmUqPVCUVuVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gh2Dd6JsVSeJC01z77iaLK5lbj8x0EMWir0X9I1E97l7BPg6LUTMV0yzJovqEDRk9 KFcLLjPelhffkufnjBfWq9FkF/jiO/uTeYbErsdfAi6YhMLvo10IEmcV6cWvLNkGmH kCu7QFmUg5gtJ28MZJKQPpyB9GSMp9pU0Jtdbp+7J4Hgoe/iTCOxWBpKJ8mKI8AWlT EqAx1hdBRgyPnNT6Ddhjh9zpVWQpHP2sZe/a+CChK6ukexnhXAIodrPeAj8nu0W5yB 4Keerrfeq4CU6YaU176BUgnYyQEDu524A9RaGTVOQsTdWE7VT35tRFvIum1PQg/eIK iGm6kAfKQrjsw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yifan Zhang , Alex Deucher , Greg Kroah-Hartman Subject: [PATCH 5.4 02/71] Revert "drm/amdgpu/gfx9: fix the doorbell missing when in CGPG issue." Date: Mon, 28 Jun 2021 10:28:55 -0400 Message-Id: <20210628143004.32596-3-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210628143004.32596-1-sashal@kernel.org> References: <20210628143004.32596-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.129-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.129-rc1 X-KernelTest-Deadline: 2021-06-30T14:29+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yifan Zhang commit ee5468b9f1d3bf48082eed351dace14598e8ca39 upstream. This reverts commit 4cbbe34807938e6e494e535a68d5ff64edac3f20. Reason for revert: side effect of enlarging CP_MEC_DOORBELL_RANGE may cause some APUs fail to enter gfxoff in certain user cases. Signed-off-by: Yifan Zhang Acked-by: Alex Deucher Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 354da41f52de..06cdc22b5501 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -3593,12 +3593,8 @@ static int gfx_v9_0_kiq_init_register(struct amdgpu_ring *ring) if (ring->use_doorbell) { WREG32_SOC15(GC, 0, mmCP_MEC_DOORBELL_RANGE_LOWER, (adev->doorbell_index.kiq * 2) << 2); - /* If GC has entered CGPG, ringing doorbell > first page doesn't - * wakeup GC. Enlarge CP_MEC_DOORBELL_RANGE_UPPER to workaround - * this issue. - */ WREG32_SOC15(GC, 0, mmCP_MEC_DOORBELL_RANGE_UPPER, - (adev->doorbell.size - 4)); + (adev->doorbell_index.userqueue_end * 2) << 2); } WREG32_SOC15_RLC(GC, 0, mmCP_HQD_PQ_DOORBELL_CONTROL, -- 2.30.2