Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3812184pxv; Mon, 28 Jun 2021 13:33:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7DCG/a1OJqYmuTegw9LUUXWTkjHi81Gh2m6p8qg1emXT6mYkclp3DU4oXT3p6+ouEXLqr X-Received: by 2002:a6b:d009:: with SMTP id x9mr1000119ioa.199.1624912393970; Mon, 28 Jun 2021 13:33:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624912393; cv=none; d=google.com; s=arc-20160816; b=JLZ5hZGDG9jM7Uc2h5R2kY0cpuMxB8B6tQ3JeH7rLl1kmi6wBaHJrcQBLxFpHLuQEg kDHPdAvd20qyra4eyOaO7pWTj6bHLBAKb9/ImqBdgcGR4yXL7lOIR0lS1T5KX0r0Y5Td 72NIgzNxJz/leZfLKgQAGVplbAVN44ZGU4CdZmm6I/e8ljMsvr/xG+3Yr++PMgO9e94t 5BGwh3Qvb7u2ZQbB1qlEHq32Q3QAqhlyp3+qyqFp/cmQxk6eTS/crU9Si2Yh6OdIgRTp 7rB9xfSPQxa1ywRJvjRi9PoBHfzkeBhQr1LXUcndM7wSw5acnIqr+ofZJMl8qrzC/BhO P29A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+5HYf8s/RjO23CVpVlMq52H5cW0tcwOS+6ziiT/kgAQ=; b=VzpHT+vMP9XeVN+tejjZT6oKmhBYaVuB+uNmtruKTQ2wVulLJxH9+iESIzZgCvHTiQ ZT0fP1KOZv3KKhQbqAVlJ10PYt3V8t+EiPnHQOJgBxQircVxsPh1VpgcWTaM2gOclx/L pyz8HDP2VqapZ9APiQW7Ol3NF/NsjWeUUxIXwXDfGepn5d9urrRdXx2XfX6lCu0/pdBo vfXMtryx/HMg46PPqpedTCC3tzI6Ny/kItVntlBJG3B4xDgJOUFEPw7zRv4mvqPwAlD3 EN+Oc79E/zsXvTb8irjDCtO2IvH8zJSLr5u+gSCRKMkFe3WIa8TrvIPeatj1uOW0vZXJ BDbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ORhXERaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si17871384ilj.66.2021.06.28.13.32.59; Mon, 28 Jun 2021 13:33:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ORhXERaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235679AbhF1PIY (ORCPT + 99 others); Mon, 28 Jun 2021 11:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:54532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236328AbhF1OrW (ORCPT ); Mon, 28 Jun 2021 10:47:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 133F66192F; Mon, 28 Jun 2021 14:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624890998; bh=i1zJ5xSc8Sfmde+KY3el5b++VGj1rNSB8rjx38J9gXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ORhXERaLY6UGJGlBZlyVGi88Ub55syZcY1kaWKxtRauviX3rnY+rO+CEZFSIQD+vw xogBdqDC21vafhInj8yGpjIsf2aV8tIwsjN7eQlvahh3HrQKegQ8v+YK5Hv/Eg4RGp xsIfrfaViOP/OREBxBpvt0g0cguiMx4zrrApU3ecDhfKxEOXzGeJX0ik8x9DU6mood 3Bi70X5e8Td5w/gr5oUCi3GsokY/K1ejlcORWKP2Gm0VV3nhHUp/fXoLkuj0KzwJz4 vzEaRmKQKY2EyaRnY/un7lbgs6x8oMO6Rm8r9G3H6HXVri9+73/TxIbnwcJJhQeLh+ 48xNuV4X4B1BA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiapeng Chong , Abaci Robot , "David S . Miller" , Sasha Levin Subject: [PATCH 4.14 09/88] ethernet: myri10ge: Fix missing error code in myri10ge_probe() Date: Mon, 28 Jun 2021 10:35:09 -0400 Message-Id: <20210628143628.33342-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210628143628.33342-1-sashal@kernel.org> References: <20210628143628.33342-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.238-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.238-rc1 X-KernelTest-Deadline: 2021-06-30T14:36+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit f336d0b93ae978f12c5e27199f828da89b91e56a ] The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'status'. Eliminate the follow smatch warning: drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe() warn: missing error code 'status'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index a0a555052d8c..1ac2bc75edb1 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -3853,6 +3853,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent) dev_err(&pdev->dev, "invalid sram_size %dB or board span %ldB\n", mgp->sram_size, mgp->board_span); + status = -EINVAL; goto abort_with_ioremap; } memcpy_fromio(mgp->eeprom_strings, -- 2.30.2