Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755309AbWKMSUl (ORCPT ); Mon, 13 Nov 2006 13:20:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755310AbWKMSUk (ORCPT ); Mon, 13 Nov 2006 13:20:40 -0500 Received: from nf-out-0910.google.com ([64.233.182.189]:55683 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S1755309AbWKMSUk convert rfc822-to-8bit (ORCPT ); Mon, 13 Nov 2006 13:20:40 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=i16bE6/2CvlPpZ0fkSs4fviIQcxuA5TPdcH3YCiUEeE3FSnC+xXRSgjZovm2Jn36U4Bru3oPFAQ/mSApffrba651jZ69tfY6LFwGGprRzkfbkHda8qUYZxlAeIOGyP6MBWhvXID5ygAZDAlv/gv9aRhPWkmy1nWWdjaqrqZ0ASM= Message-ID: Date: Mon, 13 Nov 2006 13:20:37 -0500 From: "Dmitry Torokhov" To: "Stelian Pop" Subject: Re: [PATCH] Apple Motion Sensor driver Cc: "Andrew Morton" , "Michael Hanselmann" , "Aristeu S. Rozanski F." , "Johannes Berg" , "Benjamin Herrenschmidt" , "Paul Mackerras" , "Robert Love" , "Jean Delvare" , "Rene Nussbaumer" , "Linux Kernel Mailing List" In-Reply-To: <1163434455.23444.14.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <1163280972.32084.13.camel@localhost.localdomain> <1163431758.23444.8.camel@localhost.localdomain> <1163434455.23444.14.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 26 On 11/13/06, Stelian Pop wrote: > Le lundi 13 novembre 2006 ? 10:53 -0500, Dmitry Torokhov a ?crit : > > > > + return IS_ERR(ams_info.kthread) ? -ENODEV : 0; > > > Is there a reason why you reporting -ENODEV instead of real error code > > from kthread_run()? > > Euh... :) > > Here it comes again: > Great :) Now I wonder if I may ask you to change name of the module option from "mouse" to "joystick" (HP driver uses this name as well) because its functionality is closer to a joystick than a mouse. Otherwise you can have my Acked-by for the input part. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/