Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3861573pxv; Mon, 28 Jun 2021 15:01:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg3dF4l4YtAUBQXI617ZQcJoIW0I/w3oJlc7wgwmotsVyQA6k8pJWVu6rBLFP6DZ/fsNzY X-Received: by 2002:a05:6402:1d2d:: with SMTP id dh13mr22972919edb.282.1624917676916; Mon, 28 Jun 2021 15:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624917676; cv=none; d=google.com; s=arc-20160816; b=CEMM1PKoe792eB/GJnnf0AQLuJ22ANLvc67VbA2Fuxw0E035nBDIOG4pswP1e3RsiL 9OJcmNT9LKN5a539eyzZ0ZTTnTF961tQgaBg1ld4cjC8jt2ue00dRaA8pRqNEzyvymAA Gx4x2JURvZ3gdqa2RO4jn8lA45XTdkshuy4TJBp8pOwGAE2RI5AKtZLzZxbu2RItwAFm k0EPA1S8IjRY4DQwBHvscfsXU8ZfPcfEbJXPrUDB6NcTlRIq6Mm6WazRfmCUvCyMuTDI MtEYE01pQvHegUqrGPBgQJfJ3354DAE3M2M3M/39xJVLjnkejJd//tppud8+XAqTVRNK ULUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QK5BSQivAyZRnC+cg2UMwVobc9Z9YB57ZIkBD+A02t0=; b=aNYvOWmhATaP5VsD1pvA9kUlyC5r2VFHUWohxa0kifH03lrLS8Ho+AG5rF8aT738hw 24rzvUFnf2+qdV5WljOkb1m4Yc8HYmlGcrdeWXR1CM5s81vWimU1jqhdTcc/XYzb8QSz nP80NuP9BjzXFmpWwa9sXINexoZ7Ieo3ct29pBDYmAhpMpBIk5u5I9EtOecrH/uKYfi6 Vl1WM6B+xLrueQ+uriYnoEUGEKmzcA2+eHNtF95NZatkrAp8oXpuBr3jgE6D8I9SgnIC Q0Um2dyRzvKzt38VJxPzr/5BUAoF7bqljnDLpiq0gjqwqTMEmM2AJMQO+QyirkIzeNxL bvrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="GZB9/zFt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f4si14584185edv.30.2021.06.28.15.00.51; Mon, 28 Jun 2021 15:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="GZB9/zFt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238434AbhF1PV1 (ORCPT + 99 others); Mon, 28 Jun 2021 11:21:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:36480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234489AbhF1O63 (ORCPT ); Mon, 28 Jun 2021 10:58:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 74E5061D52; Mon, 28 Jun 2021 14:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624891234; bh=J224/aDEQH5tbRIjHUORnB3Chhaz5QjMQXBhqCYK6ik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GZB9/zFtLGIGTw0bWqv/sVev15nSPXk0xfPmRzv2ZRBfc9lUWKc2IIjvKvBhu/LHC eoeb1VcTt7vj6bSPjvL6kK9MCWqtwSU6hkfLWAAUe/N1ozSQoNicTtkn6BHmJdHql5 +nML97BBxvLtU8VZFcLOrtj0YJxuEUnSq9RIPGZ2oOcX/Eert292JLRZExUwoSs0j2 7C11Jq+ajqSInPrCYG8LvVSTV4lH2SzF2r5m0O7P+NvlJBB9KDQmf1cC08foTY2k1X WwfuUyTesOkEXNLR/IMl5LXwYwDJ/vtwawDkQAKiAd89C1SmNJQKJehtjQXhQXc0bw swhiw0xPlapkA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavel Skripkin , "David S . Miller" , Sasha Levin Subject: [PATCH 4.9 33/71] net: hamradio: fix memory leak in mkiss_close Date: Mon, 28 Jun 2021 10:39:25 -0400 Message-Id: <20210628144003.34260-34-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210628144003.34260-1-sashal@kernel.org> References: <20210628144003.34260-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.274-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.9.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.9.274-rc1 X-KernelTest-Deadline: 2021-06-30T14:39+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin [ Upstream commit 7edcc682301492380fbdd604b4516af5ae667a13 ] My local syzbot instance hit memory leak in mkiss_open()[1]. The problem was in missing free_netdev() in mkiss_close(). In mkiss_open() netdevice is allocated and then registered, but in mkiss_close() netdevice was only unregistered, but not freed. Fail log: BUG: memory leak unreferenced object 0xffff8880281ba000 (size 4096): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): 61 78 30 00 00 00 00 00 00 00 00 00 00 00 00 00 ax0............. 00 27 fa 2a 80 88 ff ff 00 00 00 00 00 00 00 00 .'.*............ backtrace: [] kvmalloc_node+0x61/0xf0 [] alloc_netdev_mqs+0x98/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae BUG: memory leak unreferenced object 0xffff8880141a9a00 (size 96): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): e8 a2 1b 28 80 88 ff ff e8 a2 1b 28 80 88 ff ff ...(.......(.... 98 92 9c aa b0 40 02 00 00 00 00 00 00 00 00 00 .....@.......... backtrace: [] __hw_addr_create_ex+0x5b/0x310 [] __hw_addr_add_ex+0x1f8/0x2b0 [] dev_addr_init+0x10b/0x1f0 [] alloc_netdev_mqs+0x13b/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae BUG: memory leak unreferenced object 0xffff8880219bfc00 (size 512): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): 00 a0 1b 28 80 88 ff ff 80 8f b1 8d ff ff ff ff ...(............ 80 8f b1 8d ff ff ff ff 00 00 00 00 00 00 00 00 ................ backtrace: [] kvmalloc_node+0x61/0xf0 [] alloc_netdev_mqs+0x777/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae BUG: memory leak unreferenced object 0xffff888029b2b200 (size 256): comm "syz-executor.1", pid 11443, jiffies 4295046091 (age 17.660s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kvmalloc_node+0x61/0xf0 [] alloc_netdev_mqs+0x912/0xe80 [] mkiss_open+0xb2/0x6f0 [1] [] tty_ldisc_open+0x9b/0x110 [] tty_set_ldisc+0x2e8/0x670 [] tty_ioctl+0xda3/0x1440 [] __x64_sys_ioctl+0x193/0x200 [] do_syscall_64+0x3a/0xb0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae Fixes: 815f62bf7427 ("[PATCH] SMP rewrite of mkiss") Signed-off-by: Pavel Skripkin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hamradio/mkiss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 088fe5d34f50..76340bc3cf44 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -810,6 +810,7 @@ static void mkiss_close(struct tty_struct *tty) ax->tty = NULL; unregister_netdev(ax->dev); + free_netdev(ax->dev); } /* Perform I/O control on an active ax25 channel. */ -- 2.30.2