Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3914013pxv; Mon, 28 Jun 2021 16:30:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5DTKryDWyUdWpWMLPgrZ9b5ETbMuYulxu2GePZK5sp8M6pFyZOSIWWilyXDKXn0mso4m8 X-Received: by 2002:a6b:d115:: with SMTP id l21mr1571666iob.130.1624923051664; Mon, 28 Jun 2021 16:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624923051; cv=none; d=google.com; s=arc-20160816; b=ilbngPLQsuWuC7pJYy/W+eBq0Nb9gdSo4PH3HWnQPc9Wa+jS2Eh13QxJPoNOanXBeS kikxbrLMwYxPvqSu/i0KsSlZKH23KMumgT6NrMXQg3b9mt/8howPjhOhGbeuyQ5FKqmT ZFx5O1nxdOeYCxi83yiKKrfAJG3VV7yaZX/gl/6CISHduW0HsyoWE7rfJLXFoLMJvSjt sEY+iFeoFk3pCApS+jJ+VAz5Uy5la96muVfgy67p9V0ahypVEYgIcLOV4meLNQ9oHHQB 2ywfg8E+BkeFRtDnZ0AVTjfP+gxNyrXXBhcOMN+DAP7NmQkmjNI9bkVM6tY+Os4QvTQ2 rdew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8X5zZfVWnB/gr7gDeyqBRl7bW/Ce1bQhknbKy5exwjk=; b=MJCO/OGtg8AygwUfI+gOzYrPCFQikFxX237jXgHVAjCn8M6pJvMSu2aAcnRl0/gdEu jJtTixcfWzYNQsmxeabYX+EtsFl9JUgZniVvW8YAlEXa+6ET+v15gYqZM9BXAxsv0zqe EyN/dLkJDzFXctFFeoVRV2c6exxly4j6fXqxwf5N/wAYJxF1F4jsGJ89qTzhTlYTSOYC vNlbE3MrHcxE1d3L5Z3o3m0RxRg52pr8Vb1bZK6ngFBMDp9uqykj/w40bcQZMY8wlaYm IsJdp3ugrcVW5e4znew2aFmo/GW4EQMWQSG9GF4wj6fHtBRQhaKwYAwwuCVocL7eKZ73 5nLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Wl5r73Lz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si20793077iov.82.2021.06.28.16.30.39; Mon, 28 Jun 2021 16:30:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Wl5r73Lz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235920AbhF1Pdc (ORCPT + 99 others); Mon, 28 Jun 2021 11:33:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:39694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235907AbhF1PH3 (ORCPT ); Mon, 28 Jun 2021 11:07:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2035061206; Mon, 28 Jun 2021 14:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624892055; bh=/c6iu5WfXHrHMg2iHXxJCvUhPZ5Ltwmg43YDMEHHhms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wl5r73Lz+qhMKIksyfSe6Ryt7bvj3NhSo7lQSAt+hvGs69P5CL+PqJqN8Pg33w101 Pilf1iA7uPnDpXDsYCXm34HS9/peuHvLuGMwHTxI37WU1J/VpVlXF0uXjRmafzTA2r obu4bEr4ZTCj0Bi6uiMTOf9WZ+p5Iyf5g8+JenkI= Date: Mon, 28 Jun 2021 16:54:13 +0200 From: Greg KH To: Eric Auger Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, mihai.carabas@oracle.com, arnd@arndb.de, pizhenwei@bytedance.com, andriy.shevchenko@linux.intel.com, pbonzini@redhat.com, joe@perches.com Subject: Re: [PATCH] misc/pvpanic-pci: Allow automatic loading Message-ID: References: <20210628144422.895526-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628144422.895526-1-eric.auger@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote: > The pvpanic-pci driver does not auto-load and requires manual > modprobe. Let's include a device database using the > MODULE_DEVICE_TABLE macro. > > Signed-off-by: Eric Auger > --- > drivers/misc/pvpanic/pvpanic-pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c > index 9ecc4e8559d5d..30290d42d8aa8 100644 > --- a/drivers/misc/pvpanic/pvpanic-pci.c > +++ b/drivers/misc/pvpanic/pvpanic-pci.c > @@ -122,4 +122,6 @@ static struct pci_driver pvpanic_pci_driver = { > }, > }; > > +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl); > + Is this something that you need? Or is it created by a tool? thanks, greg k-h