Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: eric.auger@redhat.com
Subject: Re: [PATCH] misc/pvpanic-pci: Allow automatic loading
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
        mihai.carabas@oracle.com, arnd@arndb.de, pizhenwei@bytedance.com,
        andriy.shevchenko@linux.intel.com, pbonzini@redhat.com,
        joe@perches.com
References: <20210628144422.895526-1-eric.auger@redhat.com>
 <YNnilZ/Kg4SpU+bw@kroah.com>
From:   Eric Auger <eric.auger@redhat.com>
Message-ID: <5e3f7609-4820-6a8b-306e-553f10ce0f8a@redhat.com>
Date:   Mon, 28 Jun 2021 17:44:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <YNnilZ/Kg4SpU+bw@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi Greg,

On 6/28/21 4:54 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote:
>> The pvpanic-pci driver does not auto-load and requires manual
>> modprobe. Let's include a device database using the
>> MODULE_DEVICE_TABLE macro.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>>  drivers/misc/pvpanic/pvpanic-pci.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
>> index 9ecc4e8559d5d..30290d42d8aa8 100644
>> --- a/drivers/misc/pvpanic/pvpanic-pci.c
>> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
>> @@ -122,4 +122,6 @@ static struct pci_driver pvpanic_pci_driver = {
>>  	},
>>  };
>>  
>> +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
>> +
> Is this something that you need?  Or is it created by a tool?

the virtual machine monitor (QEMU) exposes the pvpanic-pci device to the
guest. On guest side the module exists but currently isn't loaded
automatically. So the driver fails to be probed and does not its job of
handling guest panic events. We need a SW actor that loads the module
and I thought this should be handled that way. If not, please could you
advise?

Thank you in advance

Eric 
>
> thanks,
>
> greg k-h
>