Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3918062pxv; Mon, 28 Jun 2021 16:37:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVkCZtyWmvaG+k+I9itZIPTBD95Cg1/m1Eu4xz9RCKMZ2q0zgbKI0IYSYVRWY69bdN9FpG X-Received: by 2002:a02:b0da:: with SMTP id w26mr1855344jah.42.1624923474163; Mon, 28 Jun 2021 16:37:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624923474; cv=none; d=google.com; s=arc-20160816; b=fuN0XAttH1NuI1EQ/x8VZwF6Qzq0RV7DtN69UGbLj1DgYuH1FEY2e9bYM5Jz+uttar pdGHHfxkEfKRtYdXC4/heUoHEpUqu5eJrxYTkomHDUlnpXxSsszxqUYZVEe/mx3MF9uH 8+8UaUznArtkv0YVoqTSeob00L4mhWfB36+84sIlGn14M8VTSF5fslecsTjvv3FJYwuG mI+z+cd2ikGJrCg4GPtjMHpykp9Ywtlq7F66RWEAKQdRsxDZ32+piMer6xZddH8MMNys JTt360JE858l2MwmKp28sJClFO36ji/ZtgLH0BnaRvRyHLSgihwma7z6MF2ptgkhlMdC ogGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AVS6wdnWgOLuiMtZUjGyWXos+iEGLYpsp9B+2iMmy1U=; b=WOH5yamvTue7HoSdAFYoRqqt7kAzci08OUkK2iIu/jQpa+2vdTOT5FTC6iTV1m2+D0 ZQuWyopjpof2hu9gyknZvcjzM2McKuYQ8Xt/h/GpPgA7dyxLyZuIN3WEtze8uQFRYu4f QVMCQ4AUciEkdVGUBSOKIZ/MGeQ5n5BoqkCMVlFJZJg2pVLDkDDMV1nIuX0umXxXzkjE zMIHJjelapARlYcWivJERVLBelA8XVPV8qyHf1zDsfRzw6981BOjWbro67VRCaXR5bRp 3jkDSczmwYDxGBbLHwLwdOj3CZyvqZJng0PT4QeWkjr2xFw7XAd96Mzgbq70ESB4BJ5/ 1yzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=u0sS8zoy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si23185432ilm.103.2021.06.28.16.37.42; Mon, 28 Jun 2021 16:37:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=u0sS8zoy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232856AbhF1QSz (ORCPT + 99 others); Mon, 28 Jun 2021 12:18:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbhF1QSy (ORCPT ); Mon, 28 Jun 2021 12:18:54 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A066C061574; Mon, 28 Jun 2021 09:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AVS6wdnWgOLuiMtZUjGyWXos+iEGLYpsp9B+2iMmy1U=; b=u0sS8zoyGjUHUotlbA0+9HB4p 4OXEh/9UjF/Wg+37pMDYZV6j13nPc/tC8rg/ZC7s3bCyK2XX71zq0t23x4b9HLZQ+3V7mCU6Z4iVn 2qTY8jLv9lYHQr9wQZfWZxZ8GM0IUr3aIV3limdLFQEzIiqYbnhKH81CKX3U1vC8p/6S9NGg0DLr8 pwL4gklHv3afK1PUMlggJ/f4H4g/+ojFKsztpi9j+58uDbIxU2F4QsQGNxpnrWv3gJPw//szxWDFX uFXsF/j2uoMlW9Ph1m+cQ4x0O7KAmAuWbKpQm+9s8v7N6aseagTPgKDfZ6Mp5MSQvdxhOTKEoskCp A4HgLqdLw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45434) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxtvr-0003gw-Ei; Mon, 28 Jun 2021 17:16:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lxtvo-0001Bp-Vg; Mon, 28 Jun 2021 17:16:20 +0100 Date: Mon, 28 Jun 2021 17:16:20 +0100 From: "Russell King (Oracle)" To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode Message-ID: <20210628161620.GB22278@shell.armlinux.org.uk> References: <20210628121015.22660-1-pali@kernel.org> <20210628151229.25214-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210628151229.25214-1-pali@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 05:12:29PM +0200, Pali Roh?r wrote: > Some SFP modules are not detected when i2c-fast-mode is enabled even when > clock-frequency is already set to 100000. The I2C bus violates the timing > specifications when run in fast mode. So disable fast mode on Turris Mox. Yes. SFP module specification is 100kHz max on the I2C bus, which is often forgotten about until someone runs into a problem. Acked-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!