Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3954630pxv; Mon, 28 Jun 2021 17:38:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIcXjmwA0TmBXy4aMPVi3UrOSuKyRpxd/pOEDlNCMCE6AYnQoEvwvXg2FkJMyy11Bbt9mc X-Received: by 2002:a6b:5c0a:: with SMTP id z10mr1747893ioh.122.1624927082306; Mon, 28 Jun 2021 17:38:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624927082; cv=none; d=google.com; s=arc-20160816; b=BLabDueIl4MEXp+b03bzsy28GFTT4JR678zLSM/sFDiRqT62v6wFlDM10keAglI0Qb vpH3BE7Pq0lyYZa/+RKU7+YMf3eNf9PdBIXxqIth683z0hW3ZyVov5nkXlotp0X+ttL+ qirRnv7Ox2n1ObPU/yglWT7A2hBoZK7DE5NMDv4/pvjpfeo5tpXfbNXX6acHyPxCjYku tKD3IDmNVxeIsNr+03uYUE1Z5TaeStahQk8qsNZSleEzJG/mKQqFiptonzJe1asFfXJz WMVhFA7JXzCFGbwPD2sB7c6bRWpMbS9SlAkEVi8mAMC1P3wXYQ5+wvombYV5Yz3ayyqV lPOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=JdympEUNCBOMvcqzxie9K9aqkqKda0LzTK+JOTQqbXA=; b=QcnqJdPekEAfmW1Cr0pShd4919/4MpIiU9d8Q3vq2CnsGY7gB2GLwo+xIHY/aBjiM2 ejt1tnJ8oarQ5bUqzNWBQdUZT0aWteVnkxOnLO7E5D8l1BL/1Wb4HhKyKhR8Z15A18Gw mQ7kf28wmT64BMoAfTQOhPhJB45Z8xrKZEYSs+YNbMS3SEb4C994LWrwDexYPWOiLqvN vLzpBg9BEXIiOrqo/AVvTY7zybc05OUlvnaGU2fKlk3Xs6TI9IhNOquqiNszQcuxa/IO 43dl/iAcAAOp/YHfdJ2ohUNiDnn61+8xyXzLWePoTUrI0m9U0oZJESksszZsCjpr/+ya hwIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="l1Zz2/tg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l23si16981154jaf.47.2021.06.28.17.37.51; Mon, 28 Jun 2021 17:38:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="l1Zz2/tg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235983AbhF1XCf (ORCPT + 99 others); Mon, 28 Jun 2021 19:02:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:38624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235313AbhF1XCb (ORCPT ); Mon, 28 Jun 2021 19:02:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24A7461CF8; Mon, 28 Jun 2021 23:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1624921205; bh=ZsWXc9FKF9jThbjc7um9yI6tcNaF+KHjq8t5fFUWmrc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l1Zz2/tgvo1jyws/qAAFhigF8Ji8mVZa67ZBwc7L4Z/eMFlUg6ea9eZPnW14/lGO/ T40NIIeTtGjzYibo4b1ahhUd+nquuolDPjU/RqK60dldHkZHScuun1Wm8ptLYW9hyk xeb2ycRQWVmPW/4xxPSW6iZbPhbacFkO4KvTFq28= Date: Mon, 28 Jun 2021 16:00:04 -0700 From: Andrew Morton To: Uladzislau Rezki Cc: Christoph Hellwig , Mel Gorman , linux-mm@kvack.org, LKML , Matthew Wilcox , Nicholas Piggin , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH 2/3] mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node() Message-Id: <20210628160004.ad39038af33e4be17df0d7f6@linux-foundation.org> In-Reply-To: <20210519210750.GA5615@pc638.lan> References: <20210516202056.2120-1-urezki@gmail.com> <20210516202056.2120-3-urezki@gmail.com> <20210519143900.GA2262@pc638.lan> <20210519155630.GD3672@suse.de> <20210519195214.GA2343@pc638.lan> <20210519210750.GA5615@pc638.lan> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 May 2021 23:07:50 +0200 Uladzislau Rezki wrote: > > Basically a single-page allocator is more permissive so it is a higher > > chance to success. Therefore a fallback to it makes sense. > > > Hello, Christoph. > > See below the patch. Does it sound good for you? It is about moving > page allocation part into separate function: Please just send over a patch which addresses this and Christoph's other review comments. I don't think the discussion with Mel against this patch identified any needed changes, so I'll send this series to Linus.