Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 2/2] MIPS: Loongson64: Add pm block node for
 Loongson-2K1000
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Huacai Chen <chenhuacai@kernel.org>
References: <20210628151330.11952-1-zhangqing@loongson.cn>
 <20210628151330.11952-2-zhangqing@loongson.cn>
 <697cd16e-7131-95d6-6e0b-1034d493b3ce@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   zhangqing <zhangqing@loongson.cn>
Message-ID: <b268ab7f-09d7-2a72-07e0-f497ae0c6ad1@loongson.cn>
Date:   Tue, 29 Jun 2021 09:04:10 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <697cd16e-7131-95d6-6e0b-1034d493b3ce@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 06/29/2021 12:03 AM, Sergei Shtylyov wrote:
> Hello!
>
> On 6/28/21 6:13 PM, Qing Zhang wrote:
>
>> The module is now supported, enable it.
>>
>> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
>> ---
>>
>> v3-v4:
>> No change
>>
>> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
>> ---
>>   arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> index 569e814def83..e31176ac0ac2 100644
>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> @@ -101,6 +101,15 @@ uart0: serial@1fe00000 {
>>   			no-loopback-test;
>>   		};
>>   
>> +		pm: power-controller {
>> +			device_type = "power management";
>> +			compatible = "loongson, reset-controller";
>     No spaces allowed here, AFAIK.
>
>> +			reg = <0 0x1fe0700c 0 0x8>,
>> +				<0 0x1fe07014 0 0x8>,
>> +				<0 0x1fe07030 0 0x8>;
>     Better keep those aligned...
Hi Sergei :-)

enm...

Will fix in next reversion.

Thanks.

-Qing
>
>> +			reg-names = "pm1_sts", "pm1_cnt", "rst_cnt";
>> +		};
>> +
> [...]
>
> MBR, Sergei