Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210628205947.GA10869@embeddedor>
In-Reply-To: <20210628205947.GA10869@embeddedor>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 28 Jun 2021 20:12:12 -0700
Message-ID: <CAHk-=wik-iqVYJyDxfPsOk_8vt1BrsKF-H-nunAYHw3HHuvZqA@mail.gmail.com>
Subject: Re: [GIT PULL] fallthrough fixes for Clang for 5.14-rc1
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     Kees Cook <keescook@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 28, 2021 at 1:58 PM Gustavo A. R. Silva
<gustavoars@kernel.org> wrote:
>
> Please, pull the following patches that fix many fall-through warnings
> when building with Clang 12.0.0 and this[1] change reverted. Notice
> that in order to enable -Wimplicit-fallthrough for Clang, such change[1]
> is meant to be reverted at some point. So, these patches help to move
> in that direction.

I've pulled this, but I really don't like how random it is.

Just as an example - and there are many others - look at the patch to
net/netrom/nr_route.c.

It does

                case 0:
                        nr_node->routes[0] = nr_node->routes[1];
                        fallthrough;
                case 1:
                        nr_node->routes[1] = nr_node->routes[2];
+                       fallthrough;
                case 2:
                        break;

and then about a hundred lines later it does
                case 0:
                        s->routes[0] = s->routes[1];
                        fallthrough;
                case 1:
                        s->routes[1] = s->routes[2];
+                       break;
                case 2:
                        break;

Notice? One does a 'fallthrough' to the next case that does the
'break', and the other - very much equivalent case - does a 'break'.

So the whole "add 'fallthrough' or 'break'" decision doesn't seem to
have any pattern or rule at all.

                 Linus