Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 2/2] MIPS: Loongson64: Add pm block node for
 Loongson-2K1000
To:     Qing Zhang <zhangqing@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210629011913.18611-1-zhangqing@loongson.cn>
 <20210629011913.18611-2-zhangqing@loongson.cn>
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
Message-ID: <df075ce1-0b85-e032-24d5-b028447b64ea@flygoat.com>
Date:   Tue, 29 Jun 2021 11:16:27 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210629011913.18611-2-zhangqing@loongson.cn>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


?? 2021/6/29 ????9:19, Qing Zhang д??:
> The module is now supported, enable it.
>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
>
> v4-v5:
> add missing spaces
>
>   arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> index 569e814def83..38bf14f00694 100644
> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> @@ -101,6 +101,16 @@ uart0: serial@1fe00000 {
>   			no-loopback-test;
>   		};
>   
> +		pm: power-controller {
^ power-management@1fe0700c
> +			device_type = "power management";
^ Why do you need to specify device type?
> +			compatible = "loongson, reset-controller";
^ why space?
I guess it should be loongson,ls2k-pm...

- Jiaxun
> +
> +			reg = <0 0x1fe0700c 0 0x8>,
> +			      <0 0x1fe07014 0 0x8>,
> +			      <0 0x1fe07030 0 0x8>;
> +			reg-names = "pm1_sts", "pm1_cnt", "rst_cnt";
^ I guess there is no need to specify three reg names, you can simply 
tell driver 0x1fe07000
base address and calculate them on your own.

Thanks.

- Jiaxun
> +		};
> +
>   		pci@1a000000 {
>   			compatible = "loongson,ls2k-pci";
>   			device_type = "pci";