Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755274AbWKMUmH (ORCPT ); Mon, 13 Nov 2006 15:42:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755281AbWKMUmH (ORCPT ); Mon, 13 Nov 2006 15:42:07 -0500 Received: from sd291.sivit.org ([194.146.225.122]:25868 "EHLO sd291.sivit.org") by vger.kernel.org with ESMTP id S1755274AbWKMUmE (ORCPT ); Mon, 13 Nov 2006 15:42:04 -0500 Subject: Re: [PATCH] Apple Motion Sensor driver From: Stelian Pop To: Jean Delvare Cc: Andrew Morton , Dmitry Torokhov , Michael Hanselmann , "Aristeu S. Rozanski F." , Johannes Berg , Benjamin Herrenschmidt , Paul Mackerras , Robert Love , Rene Nussbaumer , Linux Kernel Mailing List In-Reply-To: <20061113190635.597ab587.khali@linux-fr.org> References: <1163280972.32084.13.camel@localhost.localdomain> <20061113190635.597ab587.khali@linux-fr.org> Content-Type: text/plain; charset=ISO-8859-15 Date: Mon, 13 Nov 2006 21:41:59 +0100 Message-Id: <1163450519.23807.11.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2697 Lines: 59 Le lundi 13 novembre 2006 ? 19:06 +0100, Jean Delvare a ?crit : > Hi Stelian, > > On Sat, 11 Nov 2006 22:36:11 +0100, Stelian Pop wrote: > > This driver adds support for the Apple Motion Sensor (AMS) as found in 2005 > > revisions of Apple PowerBooks and iBooks. It implements both the PMU and > > I?C variants. The I?C driver and mouse emulation is based on code by > > Stelian Pop , while the PMU driver has been developped > > by Michael Hanselmann . HD parking support will be > > added later. > > > > Various people contributed fixes to this driver, including > > Aristeu Sergio Rozanski Filho and > > Jean Delvare . > > > > This patch lived for a while in the -mm tree but was dropped by Andrew in > > 2.6.18-mm1 because of some conflicting changes he was send at the time. > > Things have settled down since then, I merged all the bits and pieces and > > rediffed against the latest git. > > > > This driver should be quite mature to go directly into the input tree. If not, > > Andrew please pick it up again. > > > > (...) > > b/drivers/hwmon/ams/Makefile | 8 + > > b/drivers/hwmon/ams/ams-core.c | 265 +++++++++++++++++++++++++++++++++++ > > b/drivers/hwmon/ams/ams-i2c.c | 299 ++++++++++++++++++++++++++++++++++++++++ > > b/drivers/hwmon/ams/ams-mouse.c | 147 +++++++++++++++++++ > > b/drivers/hwmon/ams/ams-pmu.c | 207 +++++++++++++++++++++++++++ > > b/drivers/hwmon/ams/ams.h | 72 +++++++++ > > drivers/hwmon/Kconfig | 25 +++ > > drivers/hwmon/Makefile | 1 > > 8 files changed, 1024 insertions(+) > > There's some confusion here. On the one hand, you placed your driver > in the hwmon directory, and integrated it in the Hardware Monitoring > menu. But on the other hand you seem to think that the input tree is > the natural merge path for this patch. Isn't it strange? This is because I got myself confused when writing that sentence (minutes ago I was sending a patch for the appletouch driver, targeted at the input tree). I do believe that the proper place for ams is the hardware monitoring section (even if the missing HD parking APIs makes it not very useful right now). The fact that the accelerometer offers a (low res) joystick emulation is only a nice hack and I'm not even sure somebody (except Johannes) will find an use for it. -- Stelian Pop - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/