Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     linux-scsi@vger.kernel.org, Colin King <colin.king@canonical.com>,
        Hannes Reinecke <hare@suse.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8
Date:   Tue, 29 Jun 2021 00:10:06 -0400
Message-Id: <162493961194.16549.11024974338962781518.b4-ty@oracle.com>
In-Reply-To: <20210621151727.20667-1-colin.king@canonical.com>
References: <20210621151727.20667-1-colin.king@canonical.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by SA0PR12CA0029.namprd12.prod.outlook.com (2603:10b6:806:6f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Tue, 29 Jun 2021 04:10:19 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7157a764-a67e-4727-0fd0-08d93ab3cf86
X-MS-TrafficTypeDiagnostic: PH0PR10MB4711:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB47116B40FA800366286503CA8E029@PH0PR10MB4711.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: R3q4EltxjsvzJVTN6J/d4r4lWHTO4QjlfqhRxDzcKwdcY85f0Dx14Jra7EhhrbRUjB4JrSvbm1ftc+oM+cW8N+o+g/XjR3kYsxVkGhTfVIV1twSYGkeapoo/UEAV7wf4P/8jp2gJFjNEHKo5PO0ffvj5N3VNVUvfWbek3t4CcDunJkamFq8ntR61VFfM1SIKTKueLkSACWLpnnMdJgA+2lBbiGDwmRvi5mMfsgW4mdq/cku2z4kR0rGt8QCiuFMR/RTa9GJEruZK4rQJjr/v5vMk8/eaFv4ST8zAH+CuDaoMq/2URap6WE9zL9gsL+k4R+97evrV5RcJZ2LC3nGz5HB3JYV9SZ7fVMu82A9v2Sa0DZqF40BTAiXR+TXwDMlYD7vdCreLF16W0V6cVKvi4fIWur8GO4LumragMQFEGR63Px9D6XXCtu6h20xv8OgQfOphPvJMzgEBSJpJlKVLSqY0XvCOLoxPCtX3ZgDJfmON3PZL2lZt2FvJJVu0zk11652TgNCFLirOd8oHwETej1LpY+95BSyJ5uR5EH9NAhvKqMx5MvXtr1GRCTrRyUVPmv8bMinqrNR2GIgAiXze6/P0Gmm6Sl33hr6sSl0U6RSzrTFCdX63R42cCsh9rdtcsnnZDWSKNW+K67EdP3Rr5Eg+SKfkDv8R4siH9IrHJH1P/R/zrODq9B28yewGEtemteDgp8xD7o9n1DdVOW97hXyYo0cq4loQhXCt/C4xbh8BF/6lCCjitqChmk6RdKHeH0v6/J3bMa2XJd/1VEh0eSlZ3aBeI5fUkynWJFvIH/9lsa15uz+D1CgrgF1oY7BVbyqOF5yJEN9YfaOhj6U5cA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(376002)(366004)(346002)(396003)(6666004)(316002)(6486002)(966005)(26005)(38100700002)(38350700002)(110136005)(16526019)(186003)(103116003)(4326008)(956004)(478600001)(5660300002)(7696005)(52116002)(2906002)(2616005)(66946007)(4744005)(8676002)(86362001)(8936002)(36756003)(66556008)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGhlMEpjbzRMMWRCL0lWdUpUUEZMVmk4dUlFSXBOeFZCL3R4RVdQR2lsb0hT?=
 =?utf-8?B?aXpSb1dZOEk5RHh1dlpLZWJTNnpzUTFBdVRodGV2SmJENEpGMm9mREZSZjNR?=
 =?utf-8?B?YUliZEoxR2dwQ254WFA4Mit0NXVDbXlJckhndEZpN2g3ME44M1FNYUVIK3NW?=
 =?utf-8?B?WWRYZXp1STMxK1dYTG1aejFxOWRwNmhGU2M0NmFnbDlIOG5JOE1PQVcxZmp6?=
 =?utf-8?B?RDlnRjV6WmtDRjNUYXUvNVhFRnJQNk02MEwyUG1oVlM5enpFOGxDVXBoWVc5?=
 =?utf-8?B?UUV3RVM1SC81MkEvTVhKaTN5WjhicmNDMDVoYnZJQ3g5dStMYVVOejlDUkhI?=
 =?utf-8?B?d3gvVDBsR2pmb2kwakNER2I1NnVNNUpTZHVUNnZvMXMvZ1hwUlZkN0NFakVF?=
 =?utf-8?B?SFREczVBUEllbXBOOUtXNkx2ZndKQytPcnN4TUs5L3BudXhIUE9nT3JCbE96?=
 =?utf-8?B?OG1JeG1MVG1OdmZHK1hKNVlJb0JkVzgxWEQwVThiam0yZmgyVGpCdDNINGNE?=
 =?utf-8?B?UUJ1Y0tZL2pMRGROaDRsZ3pHVHlQL1NoYVRTeXNaNjJqN2JLTHhSNmpubzFx?=
 =?utf-8?B?TndDV0c5ekFxb3p0ZXNNVnhmSHIzbnZOYTJxaEE0ZW1nTHFIaDEvNUVNL1pz?=
 =?utf-8?B?S243eG1seWxQL2RlMEJWUjIyR1MyanBESVhTcmljb2tjaVE4a1lIS2RydHFr?=
 =?utf-8?B?c1huTFpZUGxJbnlEcmw5SlFpMWJ1bE80UE9FU3FJb2pFVmtDL3hOL3o1QjRJ?=
 =?utf-8?B?SmMvYm1qZURSdjQvSVZYM0U2cjU1M0tlUmQzQ1FRZDFxdjZFRnUxRG1yOWl1?=
 =?utf-8?B?cDNsS3VRWHRTSGxiUURqR0Y2VExkWkcxbnhyY3NxWE5Ka2RuVngxcm1DNUE0?=
 =?utf-8?B?Rm9CQlVueDdNUU1uajBiemd2TUwrRzhPMDRWZ2laSFBXNm0xZmpUemFBRDFN?=
 =?utf-8?B?Q000RXE4SzNPbXlRZWVrWXBnSUdMbXYvblhyK05haitqSUxubCtVOVBSYlJu?=
 =?utf-8?B?WFZLRDZESDNEK2t1aWxTQzZJRm1ld1BiYkJablkrc1N2ZHpxOUh6ZWFIVHhw?=
 =?utf-8?B?Zksrd01PUkUrVEtCdHhLaXVtNHlJQ0RLSWpzWFBYTWQwN3BBMnlMQWYwanlK?=
 =?utf-8?B?ZDQwNktRNzhNUmUyMkxJc3lad3VyVXFWcFVLZVYvTUtCam9kbHU1MndwYmFa?=
 =?utf-8?B?cWZBV2V3L04xK2dnUWF6RW1YSmtVWE01MXVIKytxcFVqUGM4WEU1aWVXLzFL?=
 =?utf-8?B?c2JQSkZ1SGUxN0RiczZvaHU3cXRtR2ZycWRqelRYcDZ4dU1KVytOdXM0dUR6?=
 =?utf-8?B?YWJpeE1iRCtpWnd1UnZ6YzN3ZzEzT2JOWi9DdlVxYkdFK2Fmd2ovczVtZDJa?=
 =?utf-8?B?R3U0M1oxU0VCSWhtQkNoM3g4UGhjVU1abkFuTkQ1UlE2MS80RmZ3L2ZHdFZB?=
 =?utf-8?B?bVpKUkFsQk5pdmZjd3dqNDArRUZqcStMRllETzlZWVlBNEVlNmtqNmVzZGJ0?=
 =?utf-8?B?V0VwcmJvMXk0d2tZVlVIbnJSb3ZFTURBQTdCN05HclBKSFV0RmR6UFRZbkpG?=
 =?utf-8?B?WXZ5eFkxUngzRVdVRS9teW5WUHplSE5IOHphcC9tM0lQQWx3RmovaUkxcDhN?=
 =?utf-8?B?TFpjd2NRTkthV01ocjJqUVFPTXYybVpFWFB0TlpmKzJtU09SUVFIT0xMdG91?=
 =?utf-8?B?ZnFpZnc1dkxzaElPTjh0Tmt5d2lxcU1WeVVMUERramgxYTVZRDR6UHJuRFJz?=
 =?utf-8?Q?PaTGtR8/lbWM6tyujTfd6E7/Co7A/ByxC2Rj0wo?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7157a764-a67e-4727-0fd0-08d93ab3cf86
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 04:10:20.6704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QinqnTIxKksCNlIUr8p4/LXlE7DhIvs/YFMwzy/bAakOPncTiTEr1CIikbJRTjP+5zOcP9UTdyOlFrL6/YFerB7jHBI5YUmMI3WHg+WFphM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4711
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10029 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2106290029
X-Proofpoint-GUID: fLzeQiYH62kRijsnvykpS3PVcVdpAaJP
X-Proofpoint-ORIG-GUID: fLzeQiYH62kRijsnvykpS3PVcVdpAaJP
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 21 Jun 2021 16:17:27 +0100, Colin King wrote:

> The shifting of the u8 integer returned fom ahc_inb(ahc, port+3) by
> 24 bits to the left will be promoted to a 32 bit signed int and then
> sign-extended to a u64. In the event that the top bit of the u8
> is set then all then all the upper 32 bits of the u64 end up as
> also being set because of the sign-extension. Fix this by
> casting the u8 values to a u64 before the 24 bit left shift.
> 
> [...]

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8
      https://git.kernel.org/mkp/scsi/c/332a9dd1d86f

-- 
Martin K. Petersen	Oracle Linux Engineering