Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4085611pxv; Mon, 28 Jun 2021 21:46:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoCYABbOD9oHzL/QyBhZPpjoT7kfIRelmxgC93NiJ07gyu0EKicZr1HftGzE/gJZLIDCke X-Received: by 2002:a17:907:7848:: with SMTP id lb8mr28543831ejc.494.1624941993774; Mon, 28 Jun 2021 21:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624941993; cv=none; d=google.com; s=arc-20160816; b=LQSlrWHJpBpokfQbrDyGHTZtQhmPtXK+OH/qVJ1jrQ8gmU1NxELiUr4hrYmcb61e07 h8Omz5PjBORcNiUcT+hGzK+EwePaFS6VpHWpbScxZ2rjV/DvxWVDnr09XKDHP/s3+cWr zeNHBQb+dviRC6a0ZOl04nk4L6M331LvapcKMpj/6RrHl7XwCuMM8/7NkzLnI53jPIlJ KWM6viIl/PyjRMgkfbmi/ALwyfPQaDE/r3nNduf/4KGTsPrn/0KGWqZ7T44FvrciUlT9 QWxc5Cu1PGsGOc/GLPGbCKgyRS4Z8Sk4V0cOz2DRDQu8wjt3wk/GkrPb7Aqm4usumnsZ eZhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kJsfnLOI4I/z5/RxykAT5MBvVfOHqHMZaoB05GPjfxQ=; b=FLg6Dk2ttWHtCDlOz+hWUapL4Le6Cc0SxUJ3x27RaKu+6Gjo83o0s0M+s8Ud3jfbEw muskuSB7Hjj6F75PL7xhUFsKQ85f/XqGIKJ2Sfpslw1X7Jdb5CgbvleNZ4Rgg9QWqxnz fGbaXxjc2GJldAX8ufJnC4I9PFXJbR0tkKGXqI2i9ayuAB7ClbBUiL2pgCLgSfOnTqIE t5fHRxyPqWGPKDwv14I9cE+2WaopPQLq7XzLwrThuDwLmYO3cQisHmti72H4OSDqAHep hQyZWCp7F20E1JAIoXjH+UjIb9mFk/x6MSbwYs55IHpjgcje4CHnP0ZfZviAoMudhot1 gAJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si18106457edb.244.2021.06.28.21.45.57; Mon, 28 Jun 2021 21:46:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbhF2Ep6 (ORCPT + 99 others); Tue, 29 Jun 2021 00:45:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbhF2Ep5 (ORCPT ); Tue, 29 Jun 2021 00:45:57 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CACCCC061574 for ; Mon, 28 Jun 2021 21:43:30 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly5ae-0003Tm-Vo; Tue, 29 Jun 2021 06:43:16 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ly5aV-0008QB-Dr; Tue, 29 Jun 2021 06:43:07 +0200 From: Oleksij Rempel To: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Heiner Kallweit , Russell King Cc: Oleksij Rempel , Marek Szyprowski , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v1 1/1] net: usb: asix: ax88772: suspend PHY on driver probe Date: Tue, 29 Jun 2021 06:43:05 +0200 Message-Id: <20210629044305.32322-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After probe/bind sequence is the PHY in active state, even if interface is stopped. As result, on some systems like Samsung Exynos5250 SoC based Arndale board, the ASIX PHY will be able to negotiate the link but fail to transmit the data. To handle it, suspend the PHY on probe. Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") Signed-off-by: Oleksij Rempel Reported-by: Marek Szyprowski Tested-by: Marek Szyprowski --- drivers/net/usb/asix_devices.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index aec97b021a73..2c115216420a 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -701,6 +701,7 @@ static int ax88772_init_phy(struct usbnet *dev) return ret; } + phy_suspend(priv->phydev); priv->phydev->mac_managed_pm = 1; phy_attached_info(priv->phydev); -- 2.30.2