Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Jun 2021 10:35:49 +0200
From:   Daniel Wagner <dwagner@suse.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Wen Xiong <wenxiong@us.ibm.com>, james.smart@broadcom.com,
        linux-kernel@vger.kernel.org, sagi@grimberg.me,
        wenxiong@linux.vnet.ibm.com
Subject: Re: [PATCH 1/1] block: System crashes when cpu hotplug + bouncing
 port
Message-ID: <20210629083549.unco3f7atybqypw3@beryllium.lan>
References: <YNqL+3LDsIPKm1ol@T590>
 <YNp1Bho5yypHkPfW@T590>
 <1624850072-17776-1-git-send-email-wenxiong@linux.vnet.ibm.com>
 <20210628090703.apaowrsazl53lza4@beryllium.lan>
 <YNmdhqd+W3XbJCwd@T590>
 <71d1ce491ed5056bfa921f0e14fa646d@imap.linux.ibm.com>
 <OFE573413D.44652DC5-ON00258703.000DB949-00258703.000EFCD4@ibm.com>
 <OF8889275F.DC758B38-ON00258703.001297BC-00258703.00143502@ibm.com>
 <YNqX6w8YHO61oqvY@T590>
 <20210629082542.vm3yh6k36d2zh3k5@beryllium.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210629082542.vm3yh6k36d2zh3k5@beryllium.lan>
Precedence: bulk

On Tue, Jun 29, 2021 at 10:25:43AM +0200, Daniel Wagner wrote:
> On Tue, Jun 29, 2021 at 11:47:55AM +0800, Ming Lei wrote:
> > >    >>data.ctx = __blk_mq_get_ctx(q, cpu);
> > >    cpu=2048 if hctx_idx = 4
> > 
> > Yeah, that is the issue I mentioned, any CPU in hctx->cpumask becomes
> > offline, please try the following patch and see if it makes a
> > difference:
> 
> Given that cpumask_first_and() will return nr_cpu_ids in this case,
> can't we just bail out here and have to caller handle the error?

To answer my own question, you want to avoid adding the if into the
hotpath.